From 8f787b66bc23b8317d95c6cf64fe6e0e6409f869 Mon Sep 17 00:00:00 2001 From: Robbie Harwood Date: Mon, 15 Apr 2019 19:54:17 -0400 Subject: [PATCH] Always initialize out cred in gp_import_gssx_cred() Signed-off-by: Robbie Harwood Reviewed-by: Simo Sorce Merges: #244 (cherry picked from commit 5697dfd94345c945f93070c40b9d4480f3d3d7ea) --- src/gp_export.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gp_export.c b/src/gp_export.c index 5e8e160..403e339 100644 --- a/src/gp_export.c +++ b/src/gp_export.c @@ -449,6 +449,8 @@ uint32_t gp_import_gssx_cred(uint32_t *min, struct gp_call_ctx *gpcall, uint32_t ret_min = 0; int ret; + *out = GSS_C_NO_CREDENTIAL; + handle = gp_service_get_creds_handle(gpcall->service); if (!handle) { ret_maj = GSS_S_FAILURE; @@ -470,7 +472,6 @@ uint32_t gp_import_gssx_cred(uint32_t *min, struct gp_call_ctx *gpcall, if (ret) { /* Allow for re-issuance of the keytab. */ GPDEBUG("Stored ccache failed to decrypt; treating as empty\n"); - *out = GSS_C_NO_CREDENTIAL; goto done; }