Blame SOURCES/Handle-gss_import_cred-failure-when-importing-gssx-c.patch

472fdf
From 5c6f2fc4f63b2812b0305a3f0de9904c5ebd38ef Mon Sep 17 00:00:00 2001
472fdf
From: Robbie Harwood <rharwood@redhat.com>
472fdf
Date: Mon, 15 Apr 2019 19:56:50 -0400
472fdf
Subject: [PATCH] Handle gss_import_cred() failure when importing gssx creds
472fdf
472fdf
Otherwise, we might attempt to set options on a non-existent handle,
472fdf
leading to a segfault.
472fdf
472fdf
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
472fdf
Reviewed-by: Simo Sorce <simo@redhat.com>
472fdf
Merges: #244
472fdf
(cherry picked from commit 84cf88f6c6cfeb8e3fd2c26ed0fe9fe5bf3810d2)
472fdf
---
472fdf
 proxy/src/gp_export.c | 4 ++++
472fdf
 1 file changed, 4 insertions(+)
472fdf
472fdf
diff --git a/proxy/src/gp_export.c b/proxy/src/gp_export.c
472fdf
index 403e339..7ad8037 100644
472fdf
--- a/proxy/src/gp_export.c
472fdf
+++ b/proxy/src/gp_export.c
472fdf
@@ -476,6 +476,10 @@ uint32_t gp_import_gssx_cred(uint32_t *min, struct gp_call_ctx *gpcall,
472fdf
     }
472fdf
 
472fdf
     ret_maj = gss_import_cred(&ret_min, &token, out);
472fdf
+    if (ret_maj) {
472fdf
+        GPDEBUG("gss_import_cred failed when importing gssx cred\n");
472fdf
+        goto done;
472fdf
+    }
472fdf
 
472fdf
     /* check if there is any client option we need to set on credentials */
472fdf
     gp_set_cred_options(cred, *out);