|
 |
16aa69 |
From 9549dc0d747d8987dd11643340adfa7b6f799460 Mon Sep 17 00:00:00 2001
|
|
|
16aa69 |
From: Peter Jones <pjones@redhat.com>
|
|
|
16aa69 |
Date: Thu, 25 Sep 2014 13:24:15 -0400
|
|
|
16aa69 |
Subject: [PATCH 24/41] Always error check getLineByType()
|
|
|
16aa69 |
|
|
|
16aa69 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
16aa69 |
---
|
|
|
16aa69 |
grubby.c | 20 +++++++++++++++-----
|
|
|
16aa69 |
1 file changed, 15 insertions(+), 5 deletions(-)
|
|
|
16aa69 |
|
|
|
16aa69 |
diff --git a/grubby.c b/grubby.c
|
|
|
16aa69 |
index f8e9c25..febc1ad 100644
|
|
|
16aa69 |
--- a/grubby.c
|
|
|
16aa69 |
+++ b/grubby.c
|
|
|
16aa69 |
@@ -2363,9 +2363,11 @@ void displayEntry(struct singleEntry * entry, const char * prefix, int index) {
|
|
|
16aa69 |
} else {
|
|
|
16aa69 |
char * title;
|
|
|
16aa69 |
line = getLineByType(LT_MENUENTRY, entry->lines);
|
|
|
16aa69 |
- title = grub2ExtractTitle(line);
|
|
|
16aa69 |
- if (title)
|
|
|
16aa69 |
- printf("title=%s\n", title);
|
|
|
16aa69 |
+ if (!line) {
|
|
|
16aa69 |
+ title = grub2ExtractTitle(line);
|
|
|
16aa69 |
+ if (title)
|
|
|
16aa69 |
+ printf("title=%s\n", title);
|
|
|
16aa69 |
+ }
|
|
|
16aa69 |
}
|
|
|
16aa69 |
}
|
|
|
16aa69 |
|
|
|
16aa69 |
@@ -3302,9 +3304,13 @@ int addMBInitrd(struct grubConfig * cfg, const char *newMBKernel,
|
|
|
16aa69 |
|
|
|
16aa69 |
/* if title is supplied, the entry's title must match it. */
|
|
|
16aa69 |
if (title) {
|
|
|
16aa69 |
+ char *linetitle;
|
|
|
16aa69 |
+
|
|
|
16aa69 |
line = getLineByType(LT_TITLE|LT_MENUENTRY, entry->lines);
|
|
|
16aa69 |
- char *linetitle = extractTitle(line);
|
|
|
16aa69 |
+ if (!line)
|
|
|
16aa69 |
+ continue;
|
|
|
16aa69 |
|
|
|
16aa69 |
+ linetitle = extractTitle(line);
|
|
|
16aa69 |
if (!linetitle)
|
|
|
16aa69 |
continue;
|
|
|
16aa69 |
if (strcmp(title, linetitle)) {
|
|
|
16aa69 |
@@ -3352,9 +3358,13 @@ int updateInitrd(struct grubConfig * cfg, const char * image,
|
|
|
16aa69 |
|
|
|
16aa69 |
/* if title is supplied, the entry's title must match it. */
|
|
|
16aa69 |
if (title) {
|
|
|
16aa69 |
+ char *linetitle;
|
|
|
16aa69 |
+
|
|
|
16aa69 |
line = getLineByType(LT_TITLE|LT_MENUENTRY, entry->lines);
|
|
|
16aa69 |
- char *linetitle = extractTitle(line);
|
|
|
16aa69 |
+ if (!line)
|
|
|
16aa69 |
+ continue;
|
|
|
16aa69 |
|
|
|
16aa69 |
+ linetitle = extractTitle(line);
|
|
|
16aa69 |
if (!linetitle)
|
|
|
16aa69 |
continue;
|
|
|
16aa69 |
if (strcmp(title, linetitle)) {
|
|
|
16aa69 |
--
|
|
|
16aa69 |
2.4.3
|
|
|
16aa69 |
|