Blame SOURCES/0408-zfsinfo-Correct-a-check-for-error-allocating-memory.patch

9723a8
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
9723a8
From: Darren Kenny <darren.kenny@oracle.com>
9723a8
Date: Thu, 26 Nov 2020 10:56:45 +0000
9723a8
Subject: [PATCH] zfsinfo: Correct a check for error allocating memory
9723a8
9723a8
While arguably the check for grub_errno is correct, we should really be
9723a8
checking the return value from the function since it is always possible
9723a8
that grub_errno was set elsewhere, making this code behave incorrectly.
9723a8
9723a8
Fixes: CID 73668
9723a8
9723a8
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
9723a8
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
9723a8
---
9723a8
 grub-core/fs/zfs/zfsinfo.c | 4 ++--
9723a8
 1 file changed, 2 insertions(+), 2 deletions(-)
9723a8
9723a8
diff --git a/grub-core/fs/zfs/zfsinfo.c b/grub-core/fs/zfs/zfsinfo.c
b71686
index c8a28acf5..bf2918018 100644
9723a8
--- a/grub-core/fs/zfs/zfsinfo.c
9723a8
+++ b/grub-core/fs/zfs/zfsinfo.c
9723a8
@@ -358,8 +358,8 @@ grub_cmd_zfs_bootfs (grub_command_t cmd __attribute__ ((unused)), int argc,
9723a8
     return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("one argument expected"));
9723a8
 
9723a8
   devname = grub_file_get_device_name (args[0]);
9723a8
-  if (grub_errno)
9723a8
-    return grub_errno;
9723a8
+  if (devname == NULL)
9723a8
+    return GRUB_ERR_OUT_OF_MEMORY;
9723a8
 
9723a8
   dev = grub_device_open (devname);
9723a8
   grub_free (devname);