Blame SOURCES/0372-zfsinfo-Correct-a-check-for-error-allocating-memory.patch
|
 |
b1bcb2 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
b1bcb2 |
From: Darren Kenny <darren.kenny@oracle.com>
|
|
|
b1bcb2 |
Date: Thu, 26 Nov 2020 10:56:45 +0000
|
|
|
b1bcb2 |
Subject: [PATCH] zfsinfo: Correct a check for error allocating memory
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
While arguably the check for grub_errno is correct, we should really be
|
|
|
b1bcb2 |
checking the return value from the function since it is always possible
|
|
|
b1bcb2 |
that grub_errno was set elsewhere, making this code behave incorrectly.
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
Fixes: CID 73668
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
|
|
|
b1bcb2 |
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
|
b1bcb2 |
---
|
|
|
b1bcb2 |
grub-core/fs/zfs/zfsinfo.c | 4 ++--
|
|
|
b1bcb2 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
diff --git a/grub-core/fs/zfs/zfsinfo.c b/grub-core/fs/zfs/zfsinfo.c
|
|
|
b1bcb2 |
index c96bf2183c0..19562cf4720 100644
|
|
|
b1bcb2 |
--- a/grub-core/fs/zfs/zfsinfo.c
|
|
|
b1bcb2 |
+++ b/grub-core/fs/zfs/zfsinfo.c
|
|
|
b1bcb2 |
@@ -356,8 +356,8 @@ grub_cmd_zfs_bootfs (grub_command_t cmd __attribute__ ((unused)), int argc,
|
|
|
b1bcb2 |
return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("one argument expected"));
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
devname = grub_file_get_device_name (args[0]);
|
|
|
b1bcb2 |
- if (grub_errno)
|
|
|
b1bcb2 |
- return grub_errno;
|
|
|
b1bcb2 |
+ if (devname == NULL)
|
|
|
b1bcb2 |
+ return GRUB_ERR_OUT_OF_MEMORY;
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
dev = grub_device_open (devname);
|
|
|
b1bcb2 |
grub_free (devname);
|