Blame SOURCES/0327-grub-core-commands-videotest.c-grub_cmd_videotest-Fi.patch

f96e0b
From d7f31079c6511e1c3092338095633ae89c744ad0 Mon Sep 17 00:00:00 2001
f96e0b
From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
f96e0b
Date: Fri, 19 Apr 2013 15:09:15 +0200
f96e0b
Subject: [PATCH 327/482] 	* grub-core/commands/videotest.c
f96e0b
 (grub_cmd_videotest): Fix error 	handling when creating text_layer
f96e0b
 failed. 	* grub-core/video/video.c (grub_video_create_render_target): 
f96e0b
 Set result to 0 on error. 	(grub_video_delete_render_target): Do not
f96e0b
 dereference NULL.
f96e0b
f96e0b
---
f96e0b
 ChangeLog                      | 8 ++++++++
f96e0b
 grub-core/commands/videotest.c | 8 ++++----
f96e0b
 grub-core/video/video.c        | 3 +++
f96e0b
 3 files changed, 15 insertions(+), 4 deletions(-)
f96e0b
f96e0b
diff --git a/ChangeLog b/ChangeLog
f96e0b
index 3799129..3d4b23d 100644
f96e0b
--- a/ChangeLog
f96e0b
+++ b/ChangeLog
f96e0b
@@ -1,5 +1,13 @@
f96e0b
 2013-04-19  Vladimir Serbinenko  <phcoder@gmail.com>
f96e0b
 
f96e0b
+	* grub-core/commands/videotest.c (grub_cmd_videotest): Fix error
f96e0b
+	handling when creating text_layer failed.
f96e0b
+	* grub-core/video/video.c (grub_video_create_render_target):
f96e0b
+	Set result to 0 on error.
f96e0b
+	(grub_video_delete_render_target): Do not dereference NULL.
f96e0b
+
f96e0b
+2013-04-19  Vladimir Serbinenko  <phcoder@gmail.com>
f96e0b
+
f96e0b
 	* grub-core/kern/elfXX.c (grub_elfXX_load): Handle
f96e0b
 	GRUB_ELF_LOAD_FLAGS_30BITS and GRUB_ELF_LOAD_FLAGS_62BITS.
f96e0b
 	* grub-core/loader/powerpc/ieee1275/linux.c (grub_linux_load32),
f96e0b
diff --git a/grub-core/commands/videotest.c b/grub-core/commands/videotest.c
f96e0b
index 2e4b3a2..2256237 100644
f96e0b
--- a/grub-core/commands/videotest.c
f96e0b
+++ b/grub-core/commands/videotest.c
f96e0b
@@ -71,10 +71,10 @@ grub_cmd_videotest (grub_command_t cmd __attribute__ ((unused)),
f96e0b
     grub_font_t fixed;
f96e0b
     struct grub_font_glyph *glyph;
f96e0b
 
f96e0b
-    grub_video_create_render_target (&text_layer, width, height,
f96e0b
-				     GRUB_VIDEO_MODE_TYPE_RGB
f96e0b
-				     | GRUB_VIDEO_MODE_TYPE_ALPHA);
f96e0b
-    if (!text_layer)
f96e0b
+    if (grub_video_create_render_target (&text_layer, width, height,
f96e0b
+					 GRUB_VIDEO_MODE_TYPE_RGB
f96e0b
+					 | GRUB_VIDEO_MODE_TYPE_ALPHA)
f96e0b
+	|| !text_layer)
f96e0b
       goto fail;
f96e0b
 
f96e0b
     grub_video_set_active_render_target (text_layer);
f96e0b
diff --git a/grub-core/video/video.c b/grub-core/video/video.c
f96e0b
index aab9b18..844f36c 100644
f96e0b
--- a/grub-core/video/video.c
f96e0b
+++ b/grub-core/video/video.c
f96e0b
@@ -339,6 +339,7 @@ grub_video_create_render_target (struct grub_video_render_target **result,
f96e0b
                                  unsigned int width, unsigned int height,
f96e0b
                                  unsigned int mode_type)
f96e0b
 {
f96e0b
+  *result = 0;
f96e0b
   if (! grub_video_adapter_active)
f96e0b
     return grub_error (GRUB_ERR_BAD_DEVICE, "no video mode activated");
f96e0b
 
f96e0b
@@ -351,6 +352,8 @@ grub_video_create_render_target (struct grub_video_render_target **result,
f96e0b
 grub_err_t
f96e0b
 grub_video_delete_render_target (struct grub_video_render_target *target)
f96e0b
 {
f96e0b
+  if (!target)
f96e0b
+    return GRUB_ERR_NONE;
f96e0b
   if (! grub_video_adapter_active)
f96e0b
     return grub_error (GRUB_ERR_BAD_DEVICE, "no video mode activated");
f96e0b
 
f96e0b
-- 
f96e0b
1.8.2.1
f96e0b