Blame SOURCES/0173-grub-core-disk-efi-efidisk.c-Transform-iterate_child.patch

f96e0b
From 143156f6eb6dc06491c5c4c9a5fad15646fa8c31 Mon Sep 17 00:00:00 2001
f96e0b
From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
f96e0b
Date: Fri, 1 Mar 2013 10:37:11 +0100
f96e0b
Subject: [PATCH 173/482] 	* grub-core/disk/efi/efidisk.c: Transform
f96e0b
 iterate_child_devices into 	a FOR_CHILDREN macro.
f96e0b
f96e0b
---
f96e0b
 ChangeLog                    |  5 ++++
f96e0b
 grub-core/disk/efi/efidisk.c | 55 +++++++++++++++++---------------------------
f96e0b
 2 files changed, 26 insertions(+), 34 deletions(-)
f96e0b
f96e0b
diff --git a/ChangeLog b/ChangeLog
f96e0b
index 986871c..ccd6c0a 100644
f96e0b
--- a/ChangeLog
f96e0b
+++ b/ChangeLog
f96e0b
@@ -1,5 +1,10 @@
f96e0b
 2013-03-01  Vladimir Serbinenko  <phcoder@gmail.com>
f96e0b
 
f96e0b
+	* grub-core/disk/efi/efidisk.c: Transform iterate_child_devices into
f96e0b
+	a FOR_CHILDREN macro.
f96e0b
+
f96e0b
+2013-03-01  Vladimir Serbinenko  <phcoder@gmail.com>
f96e0b
+
f96e0b
 	* grub-core/kern/main.c (grub_set_prefix_and_root): Strip trailing
f96e0b
 	platform from firmware path.
f96e0b
 
f96e0b
diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
f96e0b
index 19c5923..c883b2c 100644
f96e0b
--- a/grub-core/disk/efi/efidisk.c
f96e0b
+++ b/grub-core/disk/efi/efidisk.c
f96e0b
@@ -175,39 +175,29 @@ find_parent_device (struct grub_efidisk_data *devices,
f96e0b
 }
f96e0b
 
f96e0b
 static int
f96e0b
-iterate_child_devices (struct grub_efidisk_data *devices,
f96e0b
-		       struct grub_efidisk_data *d,
f96e0b
-		       int (*hook) (struct grub_efidisk_data *child))
f96e0b
+is_child (struct grub_efidisk_data *child,
f96e0b
+	  struct grub_efidisk_data *parent)
f96e0b
 {
f96e0b
-  struct grub_efidisk_data *p;
f96e0b
-
f96e0b
-  for (p = devices; p; p = p->next)
f96e0b
-    {
f96e0b
-      grub_efi_device_path_t *dp, *ldp;
f96e0b
-
f96e0b
-      dp = duplicate_device_path (p->device_path);
f96e0b
-      if (! dp)
f96e0b
-	return 0;
f96e0b
-
f96e0b
-      ldp = find_last_device_path (dp);
f96e0b
-      ldp->type = GRUB_EFI_END_DEVICE_PATH_TYPE;
f96e0b
-      ldp->subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
f96e0b
-      ldp->length[0] = sizeof (*ldp);
f96e0b
-      ldp->length[1] = 0;
f96e0b
+  grub_efi_device_path_t *dp, *ldp;
f96e0b
+  int ret;
f96e0b
 
f96e0b
-      if (grub_efi_compare_device_paths (dp, d->device_path) == 0)
f96e0b
-	if (hook (p))
f96e0b
-	  {
f96e0b
-	    grub_free (dp);
f96e0b
-	    return 1;
f96e0b
-	  }
f96e0b
+  dp = duplicate_device_path (child->device_path);
f96e0b
+  if (! dp)
f96e0b
+    return 0;
f96e0b
 
f96e0b
-      grub_free (dp);
f96e0b
-    }
f96e0b
+  ldp = find_last_device_path (dp);
f96e0b
+  ldp->type = GRUB_EFI_END_DEVICE_PATH_TYPE;
f96e0b
+  ldp->subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
f96e0b
+  ldp->length[0] = sizeof (*ldp);
f96e0b
+  ldp->length[1] = 0;
f96e0b
 
f96e0b
-  return 0;
f96e0b
+  ret = (grub_efi_compare_device_paths (dp, parent->device_path) == 0);
f96e0b
+  grub_free (dp);
f96e0b
+  return ret;
f96e0b
 }
f96e0b
 
f96e0b
+#define FOR_CHILDREN(p, dev) for (p = dev; p; p = p->next) if (is_child (p, d))
f96e0b
+
f96e0b
 /* Add a device into a list of devices in an ascending order.  */
f96e0b
 static void
f96e0b
 add_device (struct grub_efidisk_data **devices, struct grub_efidisk_data *d)
f96e0b
@@ -655,9 +645,10 @@ grub_efidisk_get_device_handle (grub_disk_t disk)
f96e0b
       {
f96e0b
 	struct grub_efidisk_data *devices;
f96e0b
 	grub_efi_handle_t handle = 0;
f96e0b
-	auto int find_partition (struct grub_efidisk_data *c);
f96e0b
+	struct grub_efidisk_data *c;
f96e0b
 
f96e0b
-	int find_partition (struct grub_efidisk_data *c)
f96e0b
+	devices = make_devices ();
f96e0b
+	FOR_CHILDREN (c, devices)
f96e0b
 	  {
f96e0b
 	    grub_efi_hard_drive_device_path_t hd;
f96e0b
 
f96e0b
@@ -673,14 +664,10 @@ grub_efidisk_get_device_handle (grub_disk_t disk)
f96e0b
 		    == hd.partition_size))
f96e0b
 	      {
f96e0b
 		handle = c->handle;
f96e0b
-		return 1;
f96e0b
+		break;
f96e0b
 	      }
f96e0b
-
f96e0b
-	    return 0;
f96e0b
 	  }
f96e0b
 
f96e0b
-	devices = make_devices ();
f96e0b
-	iterate_child_devices (devices, d, find_partition);
f96e0b
 	free_devices (devices);
f96e0b
 
f96e0b
 	if (handle != 0)
f96e0b
-- 
f96e0b
1.8.2.1
f96e0b