|
 |
4c0d37 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
4c0d37 |
From: Peter Jones <pjones@redhat.com>
|
|
|
4c0d37 |
Date: Mon, 18 Nov 2019 13:05:15 -0500
|
|
|
4c0d37 |
Subject: [PATCH] Semi-asciibetize _Print()'s formatters.
|
|
|
4c0d37 |
|
|
|
4c0d37 |
This is ascii order but with upper and lower case letters mixed, so
|
|
|
4c0d37 |
things like 'X' and 'x' that use fallthrough still stay together.
|
|
|
4c0d37 |
|
|
|
4c0d37 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
4c0d37 |
---
|
|
|
4c0d37 |
lib/print.c | 148 ++++++++++++++++++++++++++++++------------------------------
|
|
|
4c0d37 |
1 file changed, 73 insertions(+), 75 deletions(-)
|
|
|
4c0d37 |
|
|
|
4c0d37 |
diff --git a/lib/print.c b/lib/print.c
|
|
|
4c0d37 |
index 35e43c03db5..0b823481347 100644
|
|
|
4c0d37 |
--- a/lib/print.c
|
|
|
4c0d37 |
+++ b/lib/print.c
|
|
|
4c0d37 |
@@ -1067,26 +1067,26 @@ Returns:
|
|
|
4c0d37 |
Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case '0':
|
|
|
4c0d37 |
- Item.Pad = '0';
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case '-':
|
|
|
4c0d37 |
- Item.PadBefore = FALSE;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
case ',':
|
|
|
4c0d37 |
Item.Comma = TRUE;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case '.':
|
|
|
4c0d37 |
- Item.WidthParse = &Item.FieldWidth;
|
|
|
4c0d37 |
+ case '-':
|
|
|
4c0d37 |
+ Item.PadBefore = FALSE;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
case '*':
|
|
|
4c0d37 |
*Item.WidthParse = va_arg(ps->args, UINTN);
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
+ case '.':
|
|
|
4c0d37 |
+ Item.WidthParse = &Item.FieldWidth;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case '0':
|
|
|
4c0d37 |
+ Item.Pad = '0';
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
case '1':
|
|
|
4c0d37 |
case '2':
|
|
|
4c0d37 |
case '3':
|
|
|
4c0d37 |
@@ -1112,62 +1112,12 @@ Returns:
|
|
|
4c0d37 |
}
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 's':
|
|
|
4c0d37 |
- Item.Item.pw = va_arg(ps->args, CHAR16 *);
|
|
|
4c0d37 |
- if (!Item.Item.pw) {
|
|
|
4c0d37 |
- Item.Item.pw = L"(null)";
|
|
|
4c0d37 |
- }
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
case 'c':
|
|
|
4c0d37 |
Item.Scratch[0] = (CHAR16) va_arg(ps->args, UINTN);
|
|
|
4c0d37 |
Item.Scratch[1] = 0;
|
|
|
4c0d37 |
Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 'l':
|
|
|
4c0d37 |
- Item.Long = TRUE;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case 'X':
|
|
|
4c0d37 |
- Item.Width = Item.Long ? 16 : 8;
|
|
|
4c0d37 |
- Item.Pad = '0';
|
|
|
4c0d37 |
-#if __GNUC__ >= 7
|
|
|
4c0d37 |
- __attribute__ ((fallthrough));
|
|
|
4c0d37 |
-#endif
|
|
|
4c0d37 |
- case 'x':
|
|
|
4c0d37 |
- ValueToHex (
|
|
|
4c0d37 |
- Item.Scratch,
|
|
|
4c0d37 |
- Item.Long ? va_arg(ps->args, UINT64) : va_arg(ps->args, UINT32)
|
|
|
4c0d37 |
- );
|
|
|
4c0d37 |
- Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case 'g':
|
|
|
4c0d37 |
- GuidToString (Item.Scratch, va_arg(ps->args, EFI_GUID *));
|
|
|
4c0d37 |
- Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case 'u':
|
|
|
4c0d37 |
- ValueToString (
|
|
|
4c0d37 |
- Item.Scratch,
|
|
|
4c0d37 |
- Item.Comma,
|
|
|
4c0d37 |
- Item.Long ? va_arg(ps->args, UINT64) : va_arg(ps->args, UINT32)
|
|
|
4c0d37 |
- );
|
|
|
4c0d37 |
- Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case 'd':
|
|
|
4c0d37 |
- ValueToString (
|
|
|
4c0d37 |
- Item.Scratch,
|
|
|
4c0d37 |
- Item.Comma,
|
|
|
4c0d37 |
- Item.Long ? va_arg(ps->args, INT64) : va_arg(ps->args, INT32)
|
|
|
4c0d37 |
- );
|
|
|
4c0d37 |
- Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
case 'D':
|
|
|
4c0d37 |
{
|
|
|
4c0d37 |
EFI_DEVICE_PATH *dp = va_arg(ps->args, EFI_DEVICE_PATH *);
|
|
|
4c0d37 |
@@ -1180,6 +1130,23 @@ Returns:
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
}
|
|
|
4c0d37 |
|
|
|
4c0d37 |
+ case 'd':
|
|
|
4c0d37 |
+ ValueToString (
|
|
|
4c0d37 |
+ Item.Scratch,
|
|
|
4c0d37 |
+ Item.Comma,
|
|
|
4c0d37 |
+ Item.Long ? va_arg(ps->args, INT64) : va_arg(ps->args, INT32)
|
|
|
4c0d37 |
+ );
|
|
|
4c0d37 |
+ Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 'E':
|
|
|
4c0d37 |
+ Attr = ps->AttrError;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 'e':
|
|
|
4c0d37 |
+ PSETATTR(ps, ps->AttrError);
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
case 'f':
|
|
|
4c0d37 |
FloatToString (
|
|
|
4c0d37 |
Item.Scratch,
|
|
|
4c0d37 |
@@ -1189,38 +1156,69 @@ Returns:
|
|
|
4c0d37 |
Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 't':
|
|
|
4c0d37 |
- TimeToString (Item.Scratch, va_arg(ps->args, EFI_TIME *));
|
|
|
4c0d37 |
+ case 'g':
|
|
|
4c0d37 |
+ GuidToString (Item.Scratch, va_arg(ps->args, EFI_GUID *));
|
|
|
4c0d37 |
Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 'r':
|
|
|
4c0d37 |
- StatusToString (Item.Scratch, va_arg(ps->args, EFI_STATUS));
|
|
|
4c0d37 |
- Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
- break;
|
|
|
4c0d37 |
-
|
|
|
4c0d37 |
- case 'n':
|
|
|
4c0d37 |
- PSETATTR(ps, ps->AttrNorm);
|
|
|
4c0d37 |
+ case 'H':
|
|
|
4c0d37 |
+ Attr = ps->AttrHighlight;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
case 'h':
|
|
|
4c0d37 |
PSETATTR(ps, ps->AttrHighlight);
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 'e':
|
|
|
4c0d37 |
- PSETATTR(ps, ps->AttrError);
|
|
|
4c0d37 |
+ case 'l':
|
|
|
4c0d37 |
+ Item.Long = TRUE;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
case 'N':
|
|
|
4c0d37 |
Attr = ps->AttrNorm;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 'H':
|
|
|
4c0d37 |
- Attr = ps->AttrHighlight;
|
|
|
4c0d37 |
+ case 'n':
|
|
|
4c0d37 |
+ PSETATTR(ps, ps->AttrNorm);
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
- case 'E':
|
|
|
4c0d37 |
- Attr = ps->AttrError;
|
|
|
4c0d37 |
+ case 'r':
|
|
|
4c0d37 |
+ StatusToString (Item.Scratch, va_arg(ps->args, EFI_STATUS));
|
|
|
4c0d37 |
+ Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 's':
|
|
|
4c0d37 |
+ Item.Item.pw = va_arg(ps->args, CHAR16 *);
|
|
|
4c0d37 |
+ if (!Item.Item.pw) {
|
|
|
4c0d37 |
+ Item.Item.pw = L"(null)";
|
|
|
4c0d37 |
+ }
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 't':
|
|
|
4c0d37 |
+ TimeToString (Item.Scratch, va_arg(ps->args, EFI_TIME *));
|
|
|
4c0d37 |
+ Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 'u':
|
|
|
4c0d37 |
+ ValueToString (
|
|
|
4c0d37 |
+ Item.Scratch,
|
|
|
4c0d37 |
+ Item.Comma,
|
|
|
4c0d37 |
+ Item.Long ? va_arg(ps->args, UINT64) : va_arg(ps->args, UINT32)
|
|
|
4c0d37 |
+ );
|
|
|
4c0d37 |
+ Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
+ break;
|
|
|
4c0d37 |
+
|
|
|
4c0d37 |
+ case 'X':
|
|
|
4c0d37 |
+ Item.Width = Item.Long ? 16 : 8;
|
|
|
4c0d37 |
+ Item.Pad = '0';
|
|
|
4c0d37 |
+#if __GNUC__ >= 7
|
|
|
4c0d37 |
+ __attribute__ ((fallthrough));
|
|
|
4c0d37 |
+#endif
|
|
|
4c0d37 |
+ case 'x':
|
|
|
4c0d37 |
+ ValueToHex (
|
|
|
4c0d37 |
+ Item.Scratch,
|
|
|
4c0d37 |
+ Item.Long ? va_arg(ps->args, UINT64) : va_arg(ps->args, UINT32)
|
|
|
4c0d37 |
+ );
|
|
|
4c0d37 |
+ Item.Item.pw = Item.Scratch;
|
|
|
4c0d37 |
break;
|
|
|
4c0d37 |
|
|
|
4c0d37 |
default:
|