From 952a066deec0de9529d96ee3a7c27a9b78bafa24 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Sat, 14 Jul 2018 00:14:07 +0200 Subject: [PATCH] keyboard: defer position-changed till we have a rect Emitting it that soon results in JS warnings, as we don't have everything in place yet. The position-changed signal will be emitted from other locations as soon as we have it. https://gitlab.gnome.org/GNOME/gnome-shell/issues/464 Closes: #464 --- js/ui/keyboard.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 26e9a8de8..5d0cc52ab 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -530,9 +530,7 @@ var FocusTracker = new Lang.Class({ this._currentWindow = window; if (window) { this._currentWindowPositionId = this._currentWindow.connect('position-changed', () => { - if (global.display.get_grab_op() == Meta.GrabOp.NONE) - this.emit('position-changed'); - else + if (global.display.get_grab_op() != Meta.GrabOp.NONE) this.emit('reset'); }); } -- 2.26.2