|
 |
28ed8f |
From d6ead50fe230df58ddab822966d69760b00ec920 Mon Sep 17 00:00:00 2001
|
|
|
28ed8f |
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
|
|
|
28ed8f |
Date: Wed, 1 Apr 2020 14:48:10 +0200
|
|
|
28ed8f |
Subject: [PATCH 1/2] screenShield: Switch lightboxes off before unlock
|
|
|
28ed8f |
transition
|
|
|
28ed8f |
|
|
|
28ed8f |
There is no point in animating a transition with fullscreen black
|
|
|
28ed8f |
rectangles stacked on top, so switch them off before rather than
|
|
|
28ed8f |
after the transition.
|
|
|
28ed8f |
|
|
|
28ed8f |
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1158
|
|
|
28ed8f |
---
|
|
|
28ed8f |
js/ui/screenShield.js | 5 +++--
|
|
|
28ed8f |
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
28ed8f |
|
|
|
28ed8f |
diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
|
|
|
28ed8f |
index cd38f11fc8..282f29fa30 100644
|
|
|
28ed8f |
--- a/js/ui/screenShield.js
|
|
|
28ed8f |
+++ b/js/ui/screenShield.js
|
|
|
28ed8f |
@@ -1221,6 +1221,9 @@ var ScreenShield = class {
|
|
|
28ed8f |
this._isModal = false;
|
|
|
28ed8f |
}
|
|
|
28ed8f |
|
|
|
28ed8f |
+ this._longLightbox.hide();
|
|
|
28ed8f |
+ this._shortLightbox.hide();
|
|
|
28ed8f |
+
|
|
|
28ed8f |
Tweener.addTween(this._lockDialogGroup, {
|
|
|
28ed8f |
scale_x: 0,
|
|
|
28ed8f |
scale_y: 0,
|
|
|
28ed8f |
@@ -1237,8 +1240,6 @@ var ScreenShield = class {
|
|
|
28ed8f |
this._dialog = null;
|
|
|
28ed8f |
}
|
|
|
28ed8f |
|
|
|
28ed8f |
- this._longLightbox.hide();
|
|
|
28ed8f |
- this._shortLightbox.hide();
|
|
|
28ed8f |
this.actor.hide();
|
|
|
28ed8f |
|
|
|
28ed8f |
if (this._becameActiveId != 0) {
|
|
|
28ed8f |
--
|
|
|
28ed8f |
2.28.0
|
|
|
28ed8f |
|
|
|
28ed8f |
|
|
|
28ed8f |
From 39ac7cad68d8c00d98c900b35add637b01eddbbf Mon Sep 17 00:00:00 2001
|
|
|
28ed8f |
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
|
|
|
28ed8f |
Date: Tue, 31 Mar 2020 21:07:59 +0200
|
|
|
28ed8f |
Subject: [PATCH 2/2] screenShield: Wake up on deactivate()
|
|
|
28ed8f |
|
|
|
28ed8f |
Usually the screen is woken up before the shield is deactivated, but
|
|
|
28ed8f |
it is also possible to unlock the session programmatically via the
|
|
|
28ed8f |
org.gnome.ScreenSaver D-Bus API.
|
|
|
28ed8f |
|
|
|
28ed8f |
The intention is very likely not to unlock a turned off screen in
|
|
|
28ed8f |
that case. Nor does it seem like a good idea to change the lock
|
|
|
28ed8f |
state without any indication.
|
|
|
28ed8f |
|
|
|
28ed8f |
Waking up the screen is more likely to meet expectations and is
|
|
|
28ed8f |
more reasonable too, so do that.
|
|
|
28ed8f |
|
|
|
28ed8f |
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1158
|
|
|
28ed8f |
---
|
|
|
28ed8f |
js/ui/screenShield.js | 2 ++
|
|
|
28ed8f |
1 file changed, 2 insertions(+)
|
|
|
28ed8f |
|
|
|
28ed8f |
diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
|
|
|
28ed8f |
index 282f29fa30..2d0a429bee 100644
|
|
|
28ed8f |
--- a/js/ui/screenShield.js
|
|
|
28ed8f |
+++ b/js/ui/screenShield.js
|
|
|
28ed8f |
@@ -1200,6 +1200,8 @@ var ScreenShield = class {
|
|
|
28ed8f |
if (Main.sessionMode.currentMode == 'unlock-dialog')
|
|
|
28ed8f |
Main.sessionMode.popMode('unlock-dialog');
|
|
|
28ed8f |
|
|
|
28ed8f |
+ this.emit('wake-up-screen');
|
|
|
28ed8f |
+
|
|
|
28ed8f |
if (this._isGreeter) {
|
|
|
28ed8f |
// We don't want to "deactivate" any more than
|
|
|
28ed8f |
// this. In particular, we don't want to drop
|
|
|
28ed8f |
--
|
|
|
28ed8f |
2.28.0
|
|
|
28ed8f |
|