From 66e9db5f97f0abea6f276093bc765a3f1b4bbaf8 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>

Date: Tue, 5 Mar 2019 19:42:01 +0100

Subject: [PATCH] st-widget: Add missing g_return_val_if_fail()

It's a public function, so it's good practice to sanity-check its

input (unless disabled at compile time of course).

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1018

---

 src/st/st-widget.c | 6 +++++-

 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/st/st-widget.c b/src/st/st-widget.c

index db984ac9b..236e03d7f 100644

--- a/src/st/st-widget.c

+++ b/src/st/st-widget.c

@@ -598,7 +598,11 @@ get_root_theme_node (ClutterStage *stage)

 StThemeNode *

 st_widget_get_theme_node (StWidget *widget)

 {

-  StWidgetPrivate *priv = st_widget_get_instance_private (widget);

+  StWidgetPrivate *priv;

+

+  g_return_val_if_fail (ST_IS_WIDGET (widget), NULL);

+

+  priv = st_widget_get_instance_private (widget);

   if (priv->theme_node == NULL)

     {

-- 

2.29.2