|
 |
e296c6 |
From 432850e943d72daedb1d352a0332d3fdee6078e2 Mon Sep 17 00:00:00 2001
|
|
|
e296c6 |
From: Ray Strode <rstrode@redhat.com>
|
|
|
e296c6 |
Date: Sun, 24 Jan 2021 11:26:40 -0500
|
|
|
e296c6 |
Subject: [PATCH 11/15] subman: Fix some build warnings
|
|
|
e296c6 |
|
|
|
e296c6 |
---
|
|
|
e296c6 |
plugins/subman/gsd-subscription-manager.c | 8 ++++----
|
|
|
e296c6 |
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
e296c6 |
|
|
|
e296c6 |
diff --git a/plugins/subman/gsd-subscription-manager.c b/plugins/subman/gsd-subscription-manager.c
|
|
|
e296c6 |
index 46f8d35c..1f9ca447 100644
|
|
|
e296c6 |
--- a/plugins/subman/gsd-subscription-manager.c
|
|
|
e296c6 |
+++ b/plugins/subman/gsd-subscription-manager.c
|
|
|
e296c6 |
@@ -561,62 +561,62 @@ _client_register_with_keys (GsdSubscriptionManager *manager,
|
|
|
e296c6 |
if (!_client_register_start (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
g_debug ("spawning %s", LIBEXECDIR "/gsd-subman-helper");
|
|
|
e296c6 |
subprocess = g_subprocess_new (G_SUBPROCESS_FLAGS_STDIN_PIPE | G_SUBPROCESS_FLAGS_STDERR_PIPE, error,
|
|
|
e296c6 |
"pkexec", LIBEXECDIR "/gsd-subman-helper",
|
|
|
e296c6 |
"--kind", "register-with-key",
|
|
|
e296c6 |
"--address", priv->address,
|
|
|
e296c6 |
"--hostname", hostname,
|
|
|
e296c6 |
"--organisation", organisation,
|
|
|
e296c6 |
NULL);
|
|
|
e296c6 |
if (subprocess == NULL) {
|
|
|
e296c6 |
g_prefix_error (error, "failed to find pkexec: ");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
if (!g_subprocess_communicate (subprocess, stdin_buf, NULL, NULL, &stderr_buf, error)) {
|
|
|
e296c6 |
g_prefix_error (error, "failed to run pkexec: ");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
rc = g_subprocess_get_exit_status (subprocess);
|
|
|
e296c6 |
if (rc != 0) {
|
|
|
e296c6 |
if (g_bytes_get_size (stderr_buf) == 0) {
|
|
|
e296c6 |
g_set_error_literal (error, G_IO_ERROR, rc,
|
|
|
e296c6 |
"Failed to run helper without stderr");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
g_set_error (error, G_IO_ERROR, rc,
|
|
|
e296c6 |
"%.*s",
|
|
|
e296c6 |
- g_bytes_get_size (stderr_buf),
|
|
|
e296c6 |
- g_bytes_get_data (stderr_buf, NULL));
|
|
|
e296c6 |
+ (int) g_bytes_get_size (stderr_buf),
|
|
|
e296c6 |
+ (char *) g_bytes_get_data (stderr_buf, NULL));
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
/* FIXME: also do on error? */
|
|
|
e296c6 |
if (!_client_register_stop (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
if (!_client_subscription_status_update (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
_client_maybe__show_notification (manager);
|
|
|
e296c6 |
|
|
|
e296c6 |
/* success */
|
|
|
e296c6 |
return TRUE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
static gboolean
|
|
|
e296c6 |
_client_register (GsdSubscriptionManager *manager,
|
|
|
e296c6 |
const gchar *hostname,
|
|
|
e296c6 |
const gchar *organisation,
|
|
|
e296c6 |
const gchar *username,
|
|
|
e296c6 |
const gchar *password,
|
|
|
e296c6 |
GError **error)
|
|
|
e296c6 |
{
|
|
|
e296c6 |
GsdSubscriptionManagerPrivate *priv = manager->priv;
|
|
|
e296c6 |
g_autoptr(GSubprocess) subprocess = NULL;
|
|
|
e296c6 |
g_autoptr(GBytes) stdin_buf = g_bytes_new (password, strlen (password) + 1);
|
|
|
e296c6 |
g_autoptr(GBytes) stderr_buf = NULL;
|
|
|
e296c6 |
gint rc;
|
|
|
e296c6 |
|
|
|
e296c6 |
/* fallback */
|
|
|
e296c6 |
if (organisation == NULL)
|
|
|
e296c6 |
organisation = "";
|
|
|
e296c6 |
@@ -628,62 +628,62 @@ _client_register (GsdSubscriptionManager *manager,
|
|
|
e296c6 |
g_debug ("spawning %s", LIBEXECDIR "/gsd-subman-helper");
|
|
|
e296c6 |
subprocess = g_subprocess_new (G_SUBPROCESS_FLAGS_STDIN_PIPE | G_SUBPROCESS_FLAGS_STDERR_PIPE,
|
|
|
e296c6 |
error,
|
|
|
e296c6 |
"pkexec", LIBEXECDIR "/gsd-subman-helper",
|
|
|
e296c6 |
"--kind", "register-with-username",
|
|
|
e296c6 |
"--address", priv->address,
|
|
|
e296c6 |
"--hostname", hostname,
|
|
|
e296c6 |
"--organisation", organisation,
|
|
|
e296c6 |
"--username", username,
|
|
|
e296c6 |
NULL);
|
|
|
e296c6 |
if (subprocess == NULL) {
|
|
|
e296c6 |
g_prefix_error (error, "failed to find pkexec: ");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
if (!g_subprocess_communicate (subprocess, stdin_buf, NULL, NULL, &stderr_buf, error)) {
|
|
|
e296c6 |
g_prefix_error (error, "failed to run pkexec: ");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
rc = g_subprocess_get_exit_status (subprocess);
|
|
|
e296c6 |
if (rc != 0) {
|
|
|
e296c6 |
if (g_bytes_get_size (stderr_buf) == 0) {
|
|
|
e296c6 |
g_set_error_literal (error, G_IO_ERROR, rc,
|
|
|
e296c6 |
"Failed to run helper without stderr");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
g_set_error (error, G_IO_ERROR, rc,
|
|
|
e296c6 |
"%.*s",
|
|
|
e296c6 |
- g_bytes_get_size (stderr_buf),
|
|
|
e296c6 |
- g_bytes_get_data (stderr_buf, NULL));
|
|
|
e296c6 |
+ (int) g_bytes_get_size (stderr_buf),
|
|
|
e296c6 |
+ (char *) g_bytes_get_data (stderr_buf, NULL));
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
/* FIXME: also do on error? */
|
|
|
e296c6 |
if (!_client_register_stop (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
if (!_client_subscription_status_update (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
_client_maybe__show_notification (manager);
|
|
|
e296c6 |
return TRUE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
|
|
|
e296c6 |
static gboolean
|
|
|
e296c6 |
_client_unregister (GsdSubscriptionManager *manager, GError **error)
|
|
|
e296c6 |
{
|
|
|
e296c6 |
g_autoptr(GSubprocess) subprocess = NULL;
|
|
|
e296c6 |
|
|
|
e296c6 |
/* apparently: "we can't send registration credentials over the regular
|
|
|
e296c6 |
* system or session bus since those aren't really locked down..." */
|
|
|
e296c6 |
if (!_client_register_start (manager, error))
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
g_debug ("spawning %s", LIBEXECDIR "/gsd-subman-helper");
|
|
|
e296c6 |
subprocess = g_subprocess_new (G_SUBPROCESS_FLAGS_STDERR_PIPE, error,
|
|
|
e296c6 |
"pkexec", LIBEXECDIR "/gsd-subman-helper",
|
|
|
e296c6 |
"--kind", "unregister",
|
|
|
e296c6 |
NULL);
|
|
|
e296c6 |
if (subprocess == NULL) {
|
|
|
e296c6 |
g_prefix_error (error, "failed to find pkexec: ");
|
|
|
e296c6 |
return FALSE;
|
|
|
e296c6 |
}
|
|
|
e296c6 |
if (!_client_subprocess_wait_check (subprocess, error))
|
|
|
e296c6 |
--
|
|
|
e296c6 |
2.30.0
|
|
|
e296c6 |
|