From 80475bf8a70342316aaa6e66ae0ca8a4a61487e9 Mon Sep 17 00:00:00 2001 From: Poornima G Date: Fri, 17 Feb 2017 12:17:18 +0530 Subject: [PATCH 372/375] readdir-ahead: Remove unnecessary logging dict_get_int can return < 0 when key is not found is a valid case. Hence no need to log > Reviewed-on: https://review.gluster.org/16654 > NetBSD-regression: NetBSD Build System > CentOS-regression: Gluster Build System > Smoke: Gluster Build System > Reviewed-by: Jeff Darcy > Signed-off-by: Poornima G Change-Id: If0795b0f178adbb94b10efc563506993f7411962 BUG: 1427096 Signed-off-by: Poornima G Reviewed-on: https://code.engineering.redhat.com/gerrit/102612 Reviewed-by: Atin Mukherjee --- xlators/performance/readdir-ahead/src/readdir-ahead.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xlators/performance/readdir-ahead/src/readdir-ahead.c b/xlators/performance/readdir-ahead/src/readdir-ahead.c index f95be50..9f129aa 100644 --- a/xlators/performance/readdir-ahead/src/readdir-ahead.c +++ b/xlators/performance/readdir-ahead/src/readdir-ahead.c @@ -577,12 +577,6 @@ rda_opendir(call_frame_t *frame, xlator_t *this, loc_t *loc, fd_t *fd, local->xattrs = xdata_from_req; ret = dict_get_int32 (xdata, GF_READDIR_SKIP_DIRS, &local->skip_dir); - if (ret < 0) { - gf_msg (this->name, GF_LOG_ERROR, - 0, READDIR_AHEAD_MSG_DICT_OP_FAILED, - "Dict get of key:%s failed with :%d", - GF_READDIR_SKIP_DIRS, ret); - } frame->local = local; } -- 1.8.3.1