From e4281000b469badb23481b1f6e9a4a2be9446adf Mon Sep 17 00:00:00 2001 From: Jeff Darcy Date: Wed, 8 Feb 2017 19:45:46 -0500 Subject: [PATCH 328/361] libglusterfs: fix serious leak of xlator_t structures There's a lot of logic (and some long comments) around how to free these structures safely, but then we didn't do it. Now we do. mainline: > BUG: 1420571 > Reviewed-on: https://review.gluster.org/16570 > Smoke: Gluster Build System > NetBSD-regression: NetBSD Build System > CentOS-regression: Gluster Build System > Reviewed-by: Poornima G > Reviewed-by: Shyamsundar Ranganathan (cherry picked from commit 1411b174105e7b476eeb8c0d565ba157443a4353) BUG: 1417815 Change-Id: I9731ae75c60e99cc43d33d0813a86912db97fd96 Signed-off-by: Jeff Darcy Reviewed-on: https://code.engineering.redhat.com/gerrit/101309 Tested-by: Milind Changire Reviewed-by: Atin Mukherjee --- libglusterfs/src/xlator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index fd3b06d..e6807c5 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -735,6 +735,7 @@ xlator_tree_free_memacct (xlator_t *tree) while (prev) { trav = prev->next; xlator_memrec_free (prev); + GF_FREE (prev); prev = trav; } -- 1.8.3.1