From 808f311bd4f38f06b8afc49fc8d2c65fc4797431 Mon Sep 17 00:00:00 2001 From: kshithijiyer Date: Fri, 28 Jun 2019 15:32:31 +0530 Subject: [PATCH 332/335] Removing one top command from gluster v help The current help show 2 different top commands intead of one single top command which can be easily observed when "# gluster v help" command is issued. Removing one "volume top " and clubbing into them into a single command. Current help: volume top {open|read|write|opendir|readdir|clear} [nfs|brick ] [list-cnt ] | volume top {read-perf|write-perf} [bs count ] [brick ] [list-cnt ] - volume top operations Expected help: volume top {open|read|write|opendir|readdir|clear} [nfs|brick ] [list-cnt ] | {read-perf|write-perf} [bs count ] [brick ] [list-cnt ] - volume top operations > upstream patch: https://review.gluster.org/#/c/glusterfs/+/22972/ > fixes: bz#1725034 > Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d > Signed-off-by: kshithijiyer BUG: 1726058 Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d Signed-off-by: Sanju Rakonde Reviewed-on: https://code.engineering.redhat.com/gerrit/185757 Tested-by: RHGS Build Bot Reviewed-by: Sunil Kumar Heggodu Gopala Acharya --- cli/src/cli-cmd-volume.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c index 66beb1b..754d333 100644 --- a/cli/src/cli-cmd-volume.c +++ b/cli/src/cli-cmd-volume.c @@ -3427,8 +3427,8 @@ struct cli_cmd volume_cmds[] = { cli_cmd_volume_profile_cbk, "volume profile operations"}, {"volume top {open|read|write|opendir|readdir|clear} [nfs|brick " - "] [list-cnt ] |\n" - "volume top {read-perf|write-perf} [bs count ] " + "] [list-cnt ] | " + "{read-perf|write-perf} [bs count ] " "[brick ] [list-cnt ]", cli_cmd_volume_top_cbk, "volume top operations"}, -- 1.8.3.1