|
|
21ab4e |
From 46c6bae0b6cea8744cbae0ff4253b4945c11c4eb Mon Sep 17 00:00:00 2001
|
|
|
21ab4e |
From: moagrawa <moagrawa@redhat.com>
|
|
|
21ab4e |
Date: Fri, 28 Jul 2017 09:29:50 +0530
|
|
|
21ab4e |
Subject: [PATCH 577/587] changetimerecorder: Brick process crashed at ctr
|
|
|
21ab4e |
xlator in notify function
|
|
|
21ab4e |
|
|
|
21ab4e |
Problem: Sometime brick process is getting crash in notify function at the
|
|
|
21ab4e |
time of cleanup db connection while brick mux is enabled.
|
|
|
21ab4e |
|
|
|
21ab4e |
Solution: In changetimerrecorder (ctr) notify function after cleanup
|
|
|
21ab4e |
db connection set to db_conn to NULL to avoid reuse the same
|
|
|
21ab4e |
db connection again.
|
|
|
21ab4e |
|
|
|
21ab4e |
Note: Below is the backtrace pattern showing by brick process
|
|
|
21ab4e |
#0 0x00007ff98a30c1f7 in raise () from /lib64/libc.so.6
|
|
|
21ab4e |
#1 0x00007ff98a30d8e8 in abort () from /lib64/libc.so.6
|
|
|
21ab4e |
#2 0x00007ff98a34bf47 in __libc_message () from /lib64/libc.so.6
|
|
|
21ab4e |
#3 0x00007ff98a351b54 in malloc_printerr () from /lib64/libc.so.6
|
|
|
21ab4e |
#4 0x00007ff98a3537aa in _int_free () from /lib64/libc.so.6
|
|
|
21ab4e |
#5 0x00007ff97d95e311 in gf_sql_connection_fini (sql_connection=sql_connection@entry=0x7ff8e8496b50) at gfdb_sqlite3.c:42
|
|
|
21ab4e |
#6 0x00007ff97d95e38a in gf_sqlite3_fini (db_conn=0x7ff92ca04470) at gfdb_sqlite3.c:507
|
|
|
21ab4e |
#7 0x00007ff97d957156 in fini_db (_conn_node=0x7ff92ca04470) at gfdb_data_store.c:326
|
|
|
21ab4e |
#8 0x00007ff97db78679 in notify (this=0x7ff92c5b3670, event=9, data=0x7ff92c5b5a00) at changetimerecorder.c:2178
|
|
|
21ab4e |
#9 0x00007ff98bca0dc2 in xlator_notify (xl=0x7ff92c5b3670, event=event@entry=9, data=data@entry=0x7ff92c5b5a00) at xlator.c:549
|
|
|
21ab4e |
#10 0x00007ff98bd3ac12 in default_notify (this=this@entry=0x7ff92c5b5a00, event=9, data=data@entry=0x7ff92c5b6d50) at defaults.c:3139
|
|
|
21ab4e |
|
|
|
21ab4e |
> BUG: 1475632
|
|
|
21ab4e |
> Change-Id: Idd4bfdb4629c4799ac477ade81228065212683fb
|
|
|
21ab4e |
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
21ab4e |
> Reviewed-on: https://review.gluster.org/17888
|
|
|
21ab4e |
> Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
|
|
|
21ab4e |
> Smoke: Gluster Build System <jenkins@build.gluster.org>
|
|
|
21ab4e |
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
|
|
|
21ab4e |
> Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
21ab4e |
> (cherry picked from commit fc0fce2c8f0f4c9ca373fdc754cab6359c9fcdcb)
|
|
|
21ab4e |
|
|
|
21ab4e |
BUG: 1472129
|
|
|
21ab4e |
Change-Id: I6066d1508edee843a2cad5a9c1c2744d258c9e72
|
|
|
21ab4e |
Signed-off-by: moagrawa <moagrawa@redhat.com>
|
|
|
21ab4e |
Reviewed-on: https://code.engineering.redhat.com/gerrit/113754
|
|
|
21ab4e |
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
21ab4e |
---
|
|
|
21ab4e |
xlators/features/changetimerecorder/src/changetimerecorder.c | 2 ++
|
|
|
21ab4e |
1 file changed, 2 insertions(+)
|
|
|
21ab4e |
|
|
|
21ab4e |
diff --git a/xlators/features/changetimerecorder/src/changetimerecorder.c b/xlators/features/changetimerecorder/src/changetimerecorder.c
|
|
|
21ab4e |
index 6ce68d6..a2e5a21 100644
|
|
|
21ab4e |
--- a/xlators/features/changetimerecorder/src/changetimerecorder.c
|
|
|
21ab4e |
+++ b/xlators/features/changetimerecorder/src/changetimerecorder.c
|
|
|
21ab4e |
@@ -2180,6 +2180,8 @@ notify (xlator_t *this, int event, void *data, ...)
|
|
|
21ab4e |
CTR_MSG_CLOSE_DB_CONN_FAILED, "Failed closing "
|
|
|
21ab4e |
"db connection");
|
|
|
21ab4e |
}
|
|
|
21ab4e |
+ if (priv->_db_conn)
|
|
|
21ab4e |
+ priv->_db_conn = NULL;
|
|
|
21ab4e |
}
|
|
|
21ab4e |
ret = default_notify (this, event, data);
|
|
|
21ab4e |
|
|
|
21ab4e |
--
|
|
|
21ab4e |
1.8.3.1
|
|
|
21ab4e |
|