|
 |
17b94a |
From f3db0c99faf813e0f2e9ffcf599416555a59df1f Mon Sep 17 00:00:00 2001
|
|
|
17b94a |
From: Ashish Pandey <aspandey@redhat.com>
|
|
|
17b94a |
Date: Tue, 9 Feb 2021 16:43:35 +0530
|
|
|
17b94a |
Subject: [PATCH 542/542] xlaotrs/mgmt: Fixing coverity issue 1445996
|
|
|
17b94a |
|
|
|
17b94a |
Backport of https://github.com/gluster/glusterfs/pull/2148/commits/9785e96e0bdf6e60896570fdf5e4a6976a6f60ba
|
|
|
17b94a |
|
|
|
17b94a |
Fixing "Null pointer dereferences"
|
|
|
17b94a |
|
|
|
17b94a |
BUG: 1927235
|
|
|
17b94a |
Change-Id: Idbc014e1302d2450f97bccd028681198c0d97424
|
|
|
17b94a |
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
|
|
|
17b94a |
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
|
|
|
17b94a |
Reviewed-on: https://code.engineering.redhat.com/gerrit/237433
|
|
|
17b94a |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
17b94a |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
17b94a |
---
|
|
|
17b94a |
xlators/mgmt/glusterd/src/glusterd-volgen.c | 12 +++++++-----
|
|
|
17b94a |
1 file changed, 7 insertions(+), 5 deletions(-)
|
|
|
17b94a |
|
|
|
17b94a |
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
|
|
|
17b94a |
index a242b5c..71aed08 100644
|
|
|
17b94a |
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
|
|
|
17b94a |
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
|
|
|
17b94a |
@@ -2916,21 +2916,23 @@ validate_user_xlator_position(dict_t *this, char *key, data_t *value,
|
|
|
17b94a |
{
|
|
|
17b94a |
int ret = -1;
|
|
|
17b94a |
int i = 0;
|
|
|
17b94a |
+ char *value_str = NULL;
|
|
|
17b94a |
|
|
|
17b94a |
if (!value)
|
|
|
17b94a |
goto out;
|
|
|
17b94a |
|
|
|
17b94a |
+ value_str = data_to_str(value);
|
|
|
17b94a |
+ if (!value_str)
|
|
|
17b94a |
+ goto out;
|
|
|
17b94a |
+
|
|
|
17b94a |
if (fnmatch("user.xlator.*.*", key, 0) == 0) {
|
|
|
17b94a |
ret = 0;
|
|
|
17b94a |
goto out;
|
|
|
17b94a |
}
|
|
|
17b94a |
|
|
|
17b94a |
- char *value_str = data_to_str(value);
|
|
|
17b94a |
- if (!value_str)
|
|
|
17b94a |
- goto out;
|
|
|
17b94a |
-
|
|
|
17b94a |
int num_xlators = sizeof(server_graph_table) /
|
|
|
17b94a |
sizeof(server_graph_table[0]);
|
|
|
17b94a |
+
|
|
|
17b94a |
for (i = 0; i < num_xlators; i++) {
|
|
|
17b94a |
if (server_graph_table[i].dbg_key &&
|
|
|
17b94a |
strcmp(value_str, server_graph_table[i].dbg_key) == 0) {
|
|
|
17b94a |
@@ -2942,7 +2944,7 @@ validate_user_xlator_position(dict_t *this, char *key, data_t *value,
|
|
|
17b94a |
out:
|
|
|
17b94a |
if (ret == -1)
|
|
|
17b94a |
gf_log("glusterd", GF_LOG_ERROR, "invalid user xlator position %s = %s",
|
|
|
17b94a |
- key, value->data);
|
|
|
17b94a |
+ key, value_str);
|
|
|
17b94a |
|
|
|
17b94a |
return ret;
|
|
|
17b94a |
}
|
|
|
17b94a |
--
|
|
|
17b94a |
1.8.3.1
|
|
|
17b94a |
|