e7a346
From 3a1484c401d4293531c80532fa96c2f7cfc8aa2d Mon Sep 17 00:00:00 2001
e7a346
From: Sanju Rakonde <srakonde@redhat.com>
e7a346
Date: Wed, 19 Sep 2018 19:49:51 +0530
e7a346
Subject: [PATCH 458/493] glusterd: fix crash
e7a346
e7a346
When huge number of volumes are created, glusterd crash is seen.
e7a346
With the core dump, got to know that mgmt_lock_timer became NULL.
e7a346
Adding a null check for the same, need to explore about the root
e7a346
cause.
e7a346
e7a346
>updates: bz#1630922
e7a346
>Change-Id: I0770063fcbbbf4b24bef29e94b857b20bdfb5b85
e7a346
>Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
e7a346
e7a346
upstream patch: https://review.gluster.org/#/c/glusterfs/+/21228/
e7a346
e7a346
Change-Id: I0770063fcbbbf4b24bef29e94b857b20bdfb5b85
e7a346
BUG: 1599220
e7a346
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
e7a346
Reviewed-on: https://code.engineering.redhat.com/gerrit/158542
e7a346
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e7a346
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
e7a346
---
e7a346
 xlators/mgmt/glusterd/src/glusterd-locks.c | 2 +-
e7a346
 1 file changed, 1 insertion(+), 1 deletion(-)
e7a346
e7a346
diff --git a/xlators/mgmt/glusterd/src/glusterd-locks.c b/xlators/mgmt/glusterd/src/glusterd-locks.c
e7a346
index d75452d..d62d9dd 100644
e7a346
--- a/xlators/mgmt/glusterd/src/glusterd-locks.c
e7a346
+++ b/xlators/mgmt/glusterd/src/glusterd-locks.c
e7a346
@@ -890,7 +890,7 @@ glusterd_mgmt_v3_unlock (const char *name, uuid_t uuid, char *type)
e7a346
                 type, name);
e7a346
 
e7a346
         /* Release owner reference which was held during lock */
e7a346
-        if (mgmt_lock_timer->timer) {
e7a346
+        if (mgmt_lock_timer && mgmt_lock_timer->timer) {
e7a346
                 ret = -1;
e7a346
                 mgmt_lock_timer_xl = mgmt_lock_timer->xl;
e7a346
                 GF_VALIDATE_OR_GOTO (this->name, mgmt_lock_timer_xl, out);
e7a346
-- 
e7a346
1.8.3.1
e7a346