|
 |
17b94a |
From c38b38249fdf951565f6501ce8e9a4d01142d43e Mon Sep 17 00:00:00 2001
|
|
|
17b94a |
From: l17zhou <cynthia.zhou@nokia-sbell.com>
|
|
|
17b94a |
Date: Tue, 3 Dec 2019 07:43:35 +0200
|
|
|
17b94a |
Subject: [PATCH 456/456] add clean local after grant lock
|
|
|
17b94a |
|
|
|
17b94a |
found by flock test, without correct ref number of fd,
|
|
|
17b94a |
lock will not be correctly released.
|
|
|
17b94a |
|
|
|
17b94a |
Upstream patch:
|
|
|
17b94a |
> Upstream patch link: https://review.gluster.org/c/glusterfs/+/23794
|
|
|
17b94a |
> Fixes: bz#1779089
|
|
|
17b94a |
> Change-Id: I3e466b17c852eb219c8778e43af8ad670a8449cc
|
|
|
17b94a |
> Signed-off-by: l17zhou <cynthia.zhou@nokia-sbell.com>
|
|
|
17b94a |
|
|
|
17b94a |
BUG: 1854165
|
|
|
17b94a |
Change-Id: I3e466b17c852eb219c8778e43af8ad670a8449cc
|
|
|
17b94a |
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
|
|
|
17b94a |
Reviewed-on: https://code.engineering.redhat.com/gerrit/206673
|
|
|
17b94a |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
17b94a |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
17b94a |
---
|
|
|
17b94a |
xlators/features/locks/src/common.c | 15 ++++++++-------
|
|
|
17b94a |
1 file changed, 8 insertions(+), 7 deletions(-)
|
|
|
17b94a |
|
|
|
17b94a |
diff --git a/xlators/features/locks/src/common.c b/xlators/features/locks/src/common.c
|
|
|
17b94a |
index 0c52853..cddbfa6 100644
|
|
|
17b94a |
--- a/xlators/features/locks/src/common.c
|
|
|
17b94a |
+++ b/xlators/features/locks/src/common.c
|
|
|
17b94a |
@@ -961,7 +961,7 @@ grant_blocked_locks(xlator_t *this, pl_inode_t *pl_inode)
|
|
|
17b94a |
struct list_head granted_list;
|
|
|
17b94a |
posix_lock_t *tmp = NULL;
|
|
|
17b94a |
posix_lock_t *lock = NULL;
|
|
|
17b94a |
-
|
|
|
17b94a |
+ pl_local_t *local = NULL;
|
|
|
17b94a |
INIT_LIST_HEAD(&granted_list);
|
|
|
17b94a |
|
|
|
17b94a |
pthread_mutex_lock(&pl_inode->mutex);
|
|
|
17b94a |
@@ -976,9 +976,9 @@ grant_blocked_locks(xlator_t *this, pl_inode_t *pl_inode)
|
|
|
17b94a |
|
|
|
17b94a |
pl_trace_out(this, lock->frame, NULL, NULL, F_SETLKW, &lock->user_flock,
|
|
|
17b94a |
0, 0, NULL);
|
|
|
17b94a |
-
|
|
|
17b94a |
- STACK_UNWIND_STRICT(lk, lock->frame, 0, 0, &lock->user_flock, NULL);
|
|
|
17b94a |
-
|
|
|
17b94a |
+ local = lock->frame->local;
|
|
|
17b94a |
+ PL_STACK_UNWIND_AND_FREE(local, lk, lock->frame, 0, 0,
|
|
|
17b94a |
+ &lock->user_flock, NULL);
|
|
|
17b94a |
__destroy_lock(lock);
|
|
|
17b94a |
}
|
|
|
17b94a |
|
|
|
17b94a |
@@ -997,6 +997,7 @@ pl_send_prelock_unlock(xlator_t *this, pl_inode_t *pl_inode,
|
|
|
17b94a |
struct list_head granted_list;
|
|
|
17b94a |
posix_lock_t *tmp = NULL;
|
|
|
17b94a |
posix_lock_t *lock = NULL;
|
|
|
17b94a |
+ pl_local_t *local = NULL;
|
|
|
17b94a |
|
|
|
17b94a |
int ret = -1;
|
|
|
17b94a |
|
|
|
17b94a |
@@ -1024,9 +1025,9 @@ pl_send_prelock_unlock(xlator_t *this, pl_inode_t *pl_inode,
|
|
|
17b94a |
|
|
|
17b94a |
pl_trace_out(this, lock->frame, NULL, NULL, F_SETLKW, &lock->user_flock,
|
|
|
17b94a |
0, 0, NULL);
|
|
|
17b94a |
-
|
|
|
17b94a |
- STACK_UNWIND_STRICT(lk, lock->frame, 0, 0, &lock->user_flock, NULL);
|
|
|
17b94a |
-
|
|
|
17b94a |
+ local = lock->frame->local;
|
|
|
17b94a |
+ PL_STACK_UNWIND_AND_FREE(local, lk, lock->frame, 0, 0,
|
|
|
17b94a |
+ &lock->user_flock, NULL);
|
|
|
17b94a |
__destroy_lock(lock);
|
|
|
17b94a |
}
|
|
|
17b94a |
|
|
|
17b94a |
--
|
|
|
17b94a |
1.8.3.1
|
|
|
17b94a |
|