d84cf8
From 3ac3312d63b9dc3c15cd8765ab8b7c601b007500 Mon Sep 17 00:00:00 2001
d84cf8
From: Sunny Kumar <sunkumar@redhat.com>
d84cf8
Date: Tue, 19 Mar 2019 22:51:14 +0530
d84cf8
Subject: [PATCH 443/449] fuse : fix high sev coverity issue
d84cf8
d84cf8
This patch fixed coverity issue in fuse-bridge.c.
d84cf8
d84cf8
CID : 1398630 : Resource leak
d84cf8
CID : 1399757 : Uninitialized pointer read
d84cf8
d84cf8
Upstream patch https://review.gluster.org/c/glusterfs/+/22382
d84cf8
> updates: bz#789278
d84cf8
>
d84cf8
> Change-Id: I69f8591400ee56a5d215eeac443a8e3d7777db27
d84cf8
> Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
d84cf8
d84cf8
BUG: 1787310
d84cf8
Change-Id: Ib2c9af25019ee57131b3d384fc4b557437e75d3e
d84cf8
Signed-off-by: Csaba Henk <csaba@redhat.com>
d84cf8
Reviewed-on: https://code.engineering.redhat.com/gerrit/202759
d84cf8
Tested-by: RHGS Build Bot <nigelb@redhat.com>
d84cf8
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
d84cf8
---
d84cf8
 xlators/mount/fuse/src/fuse-bridge.c | 8 +++++++-
d84cf8
 1 file changed, 7 insertions(+), 1 deletion(-)
d84cf8
d84cf8
diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
d84cf8
index cfad2b4..d17320b 100644
d84cf8
--- a/xlators/mount/fuse/src/fuse-bridge.c
d84cf8
+++ b/xlators/mount/fuse/src/fuse-bridge.c
d84cf8
@@ -4174,6 +4174,7 @@ fuse_setxattr(xlator_t *this, fuse_in_header_t *finh, void *msg,
d84cf8
     if (ret < 0) {
d84cf8
         op_errno = -ret;
d84cf8
         GF_FREE(dict_value);
d84cf8
+        GF_FREE(newkey);
d84cf8
         goto done;
d84cf8
     }
d84cf8
 
d84cf8
@@ -5963,7 +5964,12 @@ fuse_thread_proc(void *data)
d84cf8
     ssize_t res = 0;
d84cf8
     struct iobuf *iobuf = NULL;
d84cf8
     fuse_in_header_t *finh = NULL;
d84cf8
-    struct iovec iov_in[2];
d84cf8
+    struct iovec iov_in[2] = {
d84cf8
+        {
d84cf8
+            0,
d84cf8
+        },
d84cf8
+    };
d84cf8
+
d84cf8
     void *msg = NULL;
d84cf8
     /* we need 512 extra buffer size for BATCH_FORGET fop. By tests, it is
d84cf8
        found to be reduces 'REALLOC()' in the loop */
d84cf8
-- 
d84cf8
1.8.3.1
d84cf8