9ae3f9
From 3ac3312d63b9dc3c15cd8765ab8b7c601b007500 Mon Sep 17 00:00:00 2001
9ae3f9
From: Sunny Kumar <sunkumar@redhat.com>
9ae3f9
Date: Tue, 19 Mar 2019 22:51:14 +0530
9ae3f9
Subject: [PATCH 443/449] fuse : fix high sev coverity issue
9ae3f9
9ae3f9
This patch fixed coverity issue in fuse-bridge.c.
9ae3f9
9ae3f9
CID : 1398630 : Resource leak
9ae3f9
CID : 1399757 : Uninitialized pointer read
9ae3f9
9ae3f9
Upstream patch https://review.gluster.org/c/glusterfs/+/22382
9ae3f9
> updates: bz#789278
9ae3f9
>
9ae3f9
> Change-Id: I69f8591400ee56a5d215eeac443a8e3d7777db27
9ae3f9
> Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
9ae3f9
9ae3f9
BUG: 1787310
9ae3f9
Change-Id: Ib2c9af25019ee57131b3d384fc4b557437e75d3e
9ae3f9
Signed-off-by: Csaba Henk <csaba@redhat.com>
9ae3f9
Reviewed-on: https://code.engineering.redhat.com/gerrit/202759
9ae3f9
Tested-by: RHGS Build Bot <nigelb@redhat.com>
9ae3f9
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
9ae3f9
---
9ae3f9
 xlators/mount/fuse/src/fuse-bridge.c | 8 +++++++-
9ae3f9
 1 file changed, 7 insertions(+), 1 deletion(-)
9ae3f9
9ae3f9
diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
9ae3f9
index cfad2b4..d17320b 100644
9ae3f9
--- a/xlators/mount/fuse/src/fuse-bridge.c
9ae3f9
+++ b/xlators/mount/fuse/src/fuse-bridge.c
9ae3f9
@@ -4174,6 +4174,7 @@ fuse_setxattr(xlator_t *this, fuse_in_header_t *finh, void *msg,
9ae3f9
     if (ret < 0) {
9ae3f9
         op_errno = -ret;
9ae3f9
         GF_FREE(dict_value);
9ae3f9
+        GF_FREE(newkey);
9ae3f9
         goto done;
9ae3f9
     }
9ae3f9
 
9ae3f9
@@ -5963,7 +5964,12 @@ fuse_thread_proc(void *data)
9ae3f9
     ssize_t res = 0;
9ae3f9
     struct iobuf *iobuf = NULL;
9ae3f9
     fuse_in_header_t *finh = NULL;
9ae3f9
-    struct iovec iov_in[2];
9ae3f9
+    struct iovec iov_in[2] = {
9ae3f9
+        {
9ae3f9
+            0,
9ae3f9
+        },
9ae3f9
+    };
9ae3f9
+
9ae3f9
     void *msg = NULL;
9ae3f9
     /* we need 512 extra buffer size for BATCH_FORGET fop. By tests, it is
9ae3f9
        found to be reduces 'REALLOC()' in the loop */
9ae3f9
-- 
9ae3f9
1.8.3.1
9ae3f9