17b94a
From 3ac3312d63b9dc3c15cd8765ab8b7c601b007500 Mon Sep 17 00:00:00 2001
17b94a
From: Sunny Kumar <sunkumar@redhat.com>
17b94a
Date: Tue, 19 Mar 2019 22:51:14 +0530
17b94a
Subject: [PATCH 443/449] fuse : fix high sev coverity issue
17b94a
17b94a
This patch fixed coverity issue in fuse-bridge.c.
17b94a
17b94a
CID : 1398630 : Resource leak
17b94a
CID : 1399757 : Uninitialized pointer read
17b94a
17b94a
Upstream patch https://review.gluster.org/c/glusterfs/+/22382
17b94a
> updates: bz#789278
17b94a
>
17b94a
> Change-Id: I69f8591400ee56a5d215eeac443a8e3d7777db27
17b94a
> Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
17b94a
17b94a
BUG: 1787310
17b94a
Change-Id: Ib2c9af25019ee57131b3d384fc4b557437e75d3e
17b94a
Signed-off-by: Csaba Henk <csaba@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/202759
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
17b94a
---
17b94a
 xlators/mount/fuse/src/fuse-bridge.c | 8 +++++++-
17b94a
 1 file changed, 7 insertions(+), 1 deletion(-)
17b94a
17b94a
diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
17b94a
index cfad2b4..d17320b 100644
17b94a
--- a/xlators/mount/fuse/src/fuse-bridge.c
17b94a
+++ b/xlators/mount/fuse/src/fuse-bridge.c
17b94a
@@ -4174,6 +4174,7 @@ fuse_setxattr(xlator_t *this, fuse_in_header_t *finh, void *msg,
17b94a
     if (ret < 0) {
17b94a
         op_errno = -ret;
17b94a
         GF_FREE(dict_value);
17b94a
+        GF_FREE(newkey);
17b94a
         goto done;
17b94a
     }
17b94a
 
17b94a
@@ -5963,7 +5964,12 @@ fuse_thread_proc(void *data)
17b94a
     ssize_t res = 0;
17b94a
     struct iobuf *iobuf = NULL;
17b94a
     fuse_in_header_t *finh = NULL;
17b94a
-    struct iovec iov_in[2];
17b94a
+    struct iovec iov_in[2] = {
17b94a
+        {
17b94a
+            0,
17b94a
+        },
17b94a
+    };
17b94a
+
17b94a
     void *msg = NULL;
17b94a
     /* we need 512 extra buffer size for BATCH_FORGET fop. By tests, it is
17b94a
        found to be reduces 'REALLOC()' in the loop */
17b94a
-- 
17b94a
1.8.3.1
17b94a