14f8ab
From 179213798496448316547506da65dbd9fd741dfa Mon Sep 17 00:00:00 2001
14f8ab
From: Atin Mukherjee <amukherj@redhat.com>
14f8ab
Date: Wed, 24 Apr 2019 22:02:51 +0530
14f8ab
Subject: [PATCH 436/449] glusterd: coverity fixes
14f8ab
14f8ab
Addresses the following:
14f8ab
14f8ab
* CID 1124776:  Resource leaks  (RESOURCE_LEAK) - Variable "aa" going out
14f8ab
of scope leaks the storage it points to in glusterd-volgen.c
14f8ab
14f8ab
* Bunch of CHECKED_RETURN defects in the callers of synctask_barrier_init
14f8ab
14f8ab
* CID 1400742:  Program hangs  (LOCK) - adding annotation to fix this
14f8ab
false positive
14f8ab
14f8ab
> upstream patch link: https://review.gluster.org/#/c/glusterfs/+/22615
14f8ab
> Updates: bz#789278
14f8ab
> Change-Id: I02f16e7eeb8c5cf72f7d0b29d00df4f03b3718b3
14f8ab
> Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
14f8ab
14f8ab
BUG: 1787310
14f8ab
Change-Id: I02f16e7eeb8c5cf72f7d0b29d00df4f03b3718b3
14f8ab
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/202626
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
14f8ab
---
14f8ab
 xlators/mgmt/glusterd/src/glusterd-handler.c |  6 ++++++
14f8ab
 xlators/mgmt/glusterd/src/glusterd-mgmt.c    | 24 +++++++++++++++++++-----
14f8ab
 xlators/mgmt/glusterd/src/glusterd-syncop.c  | 22 ++++++++++++++++++----
14f8ab
 xlators/mgmt/glusterd/src/glusterd-volgen.c  |  5 +++--
14f8ab
 4 files changed, 46 insertions(+), 11 deletions(-)
14f8ab
14f8ab
diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c
14f8ab
index 1f31e72..b8799ab 100644
14f8ab
--- a/xlators/mgmt/glusterd/src/glusterd-handler.c
14f8ab
+++ b/xlators/mgmt/glusterd/src/glusterd-handler.c
14f8ab
@@ -3458,6 +3458,12 @@ glusterd_friend_remove(uuid_t uuid, char *hostname)
14f8ab
     ret = glusterd_peerinfo_cleanup(peerinfo);
14f8ab
 out:
14f8ab
     gf_msg_debug(THIS->name, 0, "returning %d", ret);
14f8ab
+    /* We don't need to do a mutex unlock of peerinfo->delete_lock as the same
14f8ab
+     * will be anyway destroyed within glusterd_peerinfo_cleanup, coverity
14f8ab
+     * though cries about it
14f8ab
+     */
14f8ab
+    /* coverity[LOCK] */
14f8ab
+
14f8ab
     return ret;
14f8ab
 }
14f8ab
 
14f8ab
diff --git a/xlators/mgmt/glusterd/src/glusterd-mgmt.c b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
14f8ab
index a4915f3..1e185d7 100644
14f8ab
--- a/xlators/mgmt/glusterd/src/glusterd-mgmt.c
14f8ab
+++ b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
14f8ab
@@ -757,7 +757,10 @@ glusterd_mgmt_v3_initiate_lockdown(glusterd_op_t op, dict_t *dict,
14f8ab
 
14f8ab
     /* Sending mgmt_v3 lock req to other nodes in the cluster */
14f8ab
     gd_syncargs_init(&args, NULL);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1108,7 +1111,10 @@ glusterd_mgmt_v3_pre_validate(glusterd_op_t op, dict_t *req_dict,
14f8ab
 
14f8ab
     /* Sending Pre Validation req to other nodes in the cluster */
14f8ab
     gd_syncargs_init(&args, req_dict);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1458,7 +1464,10 @@ glusterd_mgmt_v3_brick_op(glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
14f8ab
 
14f8ab
     /* Sending brick op req to other nodes in the cluster */
14f8ab
     gd_syncargs_init(&args, op_ctx);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1722,7 +1731,9 @@ glusterd_mgmt_v3_commit(glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
14f8ab
 
14f8ab
     /* Sending commit req to other nodes in the cluster */
14f8ab
     gd_syncargs_init(&args, op_ctx);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1963,7 +1974,10 @@ glusterd_mgmt_v3_post_validate(glusterd_op_t op, int32_t op_ret, dict_t *dict,
14f8ab
 
14f8ab
     /* Sending Post Validation req to other nodes in the cluster */
14f8ab
     gd_syncargs_init(&args, req_dict);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c
14f8ab
index 9e47d14..c78983a 100644
14f8ab
--- a/xlators/mgmt/glusterd/src/glusterd-syncop.c
14f8ab
+++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c
14f8ab
@@ -1191,7 +1191,12 @@ gd_lock_op_phase(glusterd_conf_t *conf, glusterd_op_t op, dict_t *op_ctx,
14f8ab
     struct syncargs args = {0};
14f8ab
 
14f8ab
     this = THIS;
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    GF_VALIDATE_OR_GOTO("glusterd", this, out);
14f8ab
+
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1321,7 +1326,10 @@ stage_done:
14f8ab
     }
14f8ab
 
14f8ab
     gd_syncargs_init(&args, aggr_dict);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     RCU_READ_LOCK;
14f8ab
@@ -1449,7 +1457,10 @@ commit_done:
14f8ab
     }
14f8ab
 
14f8ab
     gd_syncargs_init(&args, op_ctx);
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
     origin_glusterd = is_origin_glusterd(req_dict);
14f8ab
 
14f8ab
@@ -1541,7 +1552,10 @@ gd_unlock_op_phase(glusterd_conf_t *conf, glusterd_op_t op, int *op_ret,
14f8ab
         goto out;
14f8ab
     }
14f8ab
 
14f8ab
-    synctask_barrier_init((&args));
14f8ab
+    ret = synctask_barrier_init((&args));
14f8ab
+    if (ret)
14f8ab
+        goto out;
14f8ab
+
14f8ab
     peer_cnt = 0;
14f8ab
 
14f8ab
     if (cluster_lock) {
14f8ab
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
index 6852f8e..16346e7 100644
14f8ab
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
@@ -4808,9 +4808,10 @@ nfs_option_handler(volgen_graph_t *graph, struct volopt_map_entry *vme,
14f8ab
 
14f8ab
         if (ret != -1) {
14f8ab
             ret = gf_canonicalize_path(vme->value);
14f8ab
-            if (ret)
14f8ab
+            if (ret) {
14f8ab
+                GF_FREE(aa);
14f8ab
                 return -1;
14f8ab
-
14f8ab
+            }
14f8ab
             ret = xlator_set_option(xl, aa, ret, vme->value);
14f8ab
             GF_FREE(aa);
14f8ab
         }
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab