17b94a
From 9425fd5a49a17a8f91c13632ae055a6510b0b44c Mon Sep 17 00:00:00 2001
17b94a
From: Sanju Rakonde <srakonde@redhat.com>
17b94a
Date: Fri, 17 May 2019 14:27:58 +0530
17b94a
Subject: [PATCH 435/449] glusterd: coverity fix
17b94a
17b94a
CID: 1401345 - Unused value
17b94a
17b94a
> upstream patch link: https://review.gluster.org/#/c/glusterfs/+/22737/
17b94a
> updates: bz#789278
17b94a
> Change-Id: I6b8f2611151ce0174042384b7632019c312ebae3
17b94a
> Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
17b94a
17b94a
BUG: 1787310
17b94a
Change-Id: I6b8f2611151ce0174042384b7632019c312ebae3
17b94a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/202622
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
17b94a
---
17b94a
 xlators/mgmt/glusterd/src/glusterd-utils.c | 2 +-
17b94a
 1 file changed, 1 insertion(+), 1 deletion(-)
17b94a
17b94a
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
17b94a
index 8b0fc9a..2eb2a76 100644
17b94a
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
17b94a
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
17b94a
@@ -3740,7 +3740,7 @@ glusterd_compare_friend_volume(dict_t *peer_data, int32_t count,
17b94a
          * deleting a volume, so we shouldn't be trying to create a
17b94a
          * fresh volume here which would lead to a stale entry
17b94a
          */
17b94a
-        if (stage_deleted == 0)
17b94a
+        if (!ret && stage_deleted == 0)
17b94a
             *status = GLUSTERD_VOL_COMP_UPDATE_REQ;
17b94a
         ret = 0;
17b94a
         goto out;
17b94a
-- 
17b94a
1.8.3.1
17b94a