|
 |
190130 |
From 1370db202a2a60810409f74c390448bf8fbd6998 Mon Sep 17 00:00:00 2001
|
|
|
190130 |
From: Barak Sason Rofman <bsasonro@redhat.com>
|
|
|
190130 |
Date: Sun, 9 Feb 2020 15:09:30 +0200
|
|
|
190130 |
Subject: [PATCH 429/449] dht/rebalance - fixing failure occurace due to
|
|
|
190130 |
rebalance stop
|
|
|
190130 |
|
|
|
190130 |
Probelm description:
|
|
|
190130 |
When topping rebalance, the following error messages appear in the
|
|
|
190130 |
rebalance log file:
|
|
|
190130 |
[2020-01-28 14:31:42.452070] W [dht-rebalance.c:3447:gf_defrag_process_dir] 0-distrep-dht: Found error from gf_defrag_get_entry
|
|
|
190130 |
[2020-01-28 14:31:42.452764] E [MSGID: 109111] [dht-rebalance.c:3971:gf_defrag_fix_layout] 0-distrep-dht: gf_defrag_process_dir failed for directory: /0/1/2/3/4/5/6/7/8/9/10/11/12/13/14/15/16/17/18/19/20/21/22/23/24/25/26/27/28/29/30/31
|
|
|
190130 |
[2020-01-28 14:31:42.453498] E [MSGID: 109016] [dht-rebalance.c:3906:gf_defrag_fix_layout] 0-distrep-dht: Fix layout failed for /0/1/2/3/4/5/6/7/8/9/10/11/12/13/14/15/16/17/18/19/20/21/22/23/24/25/26/27/28/29/30
|
|
|
190130 |
|
|
|
190130 |
In order to avoid seing these error messages, a modification to the
|
|
|
190130 |
error handling mechanism has been made.
|
|
|
190130 |
In addition, several log messages had been added in order to improve debugging efficiency
|
|
|
190130 |
|
|
|
190130 |
backport of https://review.gluster.org/#/c/glusterfs/+/24103/
|
|
|
190130 |
>fixes: bz#1800956
|
|
|
190130 |
>Change-Id: Ifc82dae79ab3da9fe22ee25088a2a6b855afcfcf
|
|
|
190130 |
>Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
|
|
|
190130 |
|
|
|
190130 |
BUG: 1286171
|
|
|
190130 |
Change-Id: Ifc82dae79ab3da9fe22ee25088a2a6b855afcfcf
|
|
|
190130 |
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
|
|
|
190130 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/202562
|
|
|
190130 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
190130 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
190130 |
---
|
|
|
190130 |
xlators/cluster/dht/src/dht-rebalance.c | 8 ++++++++
|
|
|
190130 |
1 file changed, 8 insertions(+)
|
|
|
190130 |
|
|
|
190130 |
diff --git a/xlators/cluster/dht/src/dht-rebalance.c b/xlators/cluster/dht/src/dht-rebalance.c
|
|
|
190130 |
index 8f31dca..88b6b54 100644
|
|
|
190130 |
--- a/xlators/cluster/dht/src/dht-rebalance.c
|
|
|
190130 |
+++ b/xlators/cluster/dht/src/dht-rebalance.c
|
|
|
190130 |
@@ -3479,6 +3479,10 @@ gf_defrag_process_dir(xlator_t *this, gf_defrag_info_t *defrag, loc_t *loc,
|
|
|
190130 |
migrate_data, dir_dfmeta, xattr_req,
|
|
|
190130 |
&should_commit_hash, perrno);
|
|
|
190130 |
|
|
|
190130 |
+ if (defrag->defrag_status == GF_DEFRAG_STATUS_STOPPED) {
|
|
|
190130 |
+ goto out;
|
|
|
190130 |
+ }
|
|
|
190130 |
+
|
|
|
190130 |
if (ret) {
|
|
|
190130 |
gf_log(this->name, GF_LOG_WARNING,
|
|
|
190130 |
"Found "
|
|
|
190130 |
@@ -3935,6 +3939,10 @@ gf_defrag_fix_layout(xlator_t *this, gf_defrag_info_t *defrag, loc_t *loc,
|
|
|
190130 |
ret = gf_defrag_fix_layout(this, defrag, &entry_loc, fix_layout,
|
|
|
190130 |
migrate_data);
|
|
|
190130 |
|
|
|
190130 |
+ if (defrag->defrag_status == GF_DEFRAG_STATUS_STOPPED) {
|
|
|
190130 |
+ goto out;
|
|
|
190130 |
+ }
|
|
|
190130 |
+
|
|
|
190130 |
if (ret && ret != 2) {
|
|
|
190130 |
gf_msg(this->name, GF_LOG_ERROR, 0, DHT_MSG_LAYOUT_FIX_FAILED,
|
|
|
190130 |
"Fix layout failed for %s", entry_loc.path);
|
|
|
190130 |
--
|
|
|
190130 |
1.8.3.1
|
|
|
190130 |
|