74096c
From 63cfdd987b1dfbf97486f0f884380faee0ae25d0 Mon Sep 17 00:00:00 2001
74096c
From: Ravishankar N <ravishankar@redhat.com>
74096c
Date: Wed, 4 Sep 2019 11:27:30 +0530
74096c
Subject: [PATCH 416/449] tests: fix spurious failure of
74096c
 bug-1402841.t-mt-dir-scan-race.t
74096c
74096c
Upstream patch: https://review.gluster.org/23352
74096c
74096c
Problem:
74096c
Since commit 600ba94183333c4af9b4a09616690994fd528478, shd starts
74096c
healing as soon as it is toggled from disabled to enabled. This was
74096c
causing the following line in the .t to fail on a 'fast' machine (always
74096c
on my laptop and sometimes on the jenkins slaves).
74096c
74096c
EXPECT_NOT "^0$" get_pending_heal_count $V0
74096c
74096c
because by the time shd was disabled, the heal was already completed.
74096c
74096c
Fix:
74096c
Increase the no. of files to be healed and make it a variable called
74096c
FILE_COUNT, should we need to bump it up further because the machines
74096c
become even faster. Also created pending metadata heals to increase the
74096c
time taken to heal a file.
74096c
74096c
>fixes: bz#1748744
74096c
>Change-Id: I5a26b08e45b8c19bce3c01ce67bdcc28ed48198d
74096c
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
74096c
74096c
BUG: 1844359
74096c
Change-Id: Ie3676c6c2c27e7574b958d2eaac23801dfaed3a9
74096c
Reviewed-on: https://code.engineering.redhat.com/gerrit/202481
74096c
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74096c
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74096c
---
74096c
 tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t | 9 +++++----
74096c
 1 file changed, 5 insertions(+), 4 deletions(-)
74096c
74096c
diff --git a/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t b/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
74096c
index 6351ba2..a1b9a85 100755
74096c
--- a/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
74096c
+++ b/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
74096c
@@ -3,6 +3,8 @@
74096c
 . $(dirname $0)/../../volume.rc
74096c
 cleanup;
74096c
 
74096c
+FILE_COUNT=500
74096c
+
74096c
 TEST glusterd
74096c
 TEST pidof glusterd
74096c
 TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}{0,1}
74096c
@@ -11,15 +13,14 @@ TEST $CLI volume set $V0 cluster.shd-wait-qlength 100
74096c
 TEST $CLI volume start $V0
74096c
 
74096c
 TEST glusterfs --volfile-id=$V0 --volfile-server=$H0 $M0;
74096c
-touch $M0/file{1..200}
74096c
-
74096c
+for i in `seq 1 $FILE_COUNT`;  do touch $M0/file$i; done
74096c
 TEST kill_brick $V0 $H0 $B0/${V0}1
74096c
-for i in {1..200}; do echo hello>$M0/file$i; done
74096c
+for i in `seq 1 $FILE_COUNT`; do echo hello>$M0/file$i; chmod -x $M0/file$i; done
74096c
 TEST $CLI volume start $V0 force
74096c
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" brick_up_status $V0 $H0 $B0/${V0}1
74096c
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" afr_child_up_status $V0 1
74096c
 
74096c
-EXPECT "200" get_pending_heal_count $V0
74096c
+EXPECT "$FILE_COUNT" get_pending_heal_count $V0
74096c
 TEST $CLI volume set $V0 self-heal-daemon on
74096c
 
74096c
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "Y" glustershd_up_status
74096c
-- 
74096c
1.8.3.1
74096c