14f8ab
From 63cfdd987b1dfbf97486f0f884380faee0ae25d0 Mon Sep 17 00:00:00 2001
14f8ab
From: Ravishankar N <ravishankar@redhat.com>
14f8ab
Date: Wed, 4 Sep 2019 11:27:30 +0530
14f8ab
Subject: [PATCH 416/449] tests: fix spurious failure of
14f8ab
 bug-1402841.t-mt-dir-scan-race.t
14f8ab
14f8ab
Upstream patch: https://review.gluster.org/23352
14f8ab
14f8ab
Problem:
14f8ab
Since commit 600ba94183333c4af9b4a09616690994fd528478, shd starts
14f8ab
healing as soon as it is toggled from disabled to enabled. This was
14f8ab
causing the following line in the .t to fail on a 'fast' machine (always
14f8ab
on my laptop and sometimes on the jenkins slaves).
14f8ab
14f8ab
EXPECT_NOT "^0$" get_pending_heal_count $V0
14f8ab
14f8ab
because by the time shd was disabled, the heal was already completed.
14f8ab
14f8ab
Fix:
14f8ab
Increase the no. of files to be healed and make it a variable called
14f8ab
FILE_COUNT, should we need to bump it up further because the machines
14f8ab
become even faster. Also created pending metadata heals to increase the
14f8ab
time taken to heal a file.
14f8ab
14f8ab
>fixes: bz#1748744
14f8ab
>Change-Id: I5a26b08e45b8c19bce3c01ce67bdcc28ed48198d
14f8ab
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
14f8ab
14f8ab
BUG: 1844359
14f8ab
Change-Id: Ie3676c6c2c27e7574b958d2eaac23801dfaed3a9
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/202481
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
14f8ab
---
14f8ab
 tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t | 9 +++++----
14f8ab
 1 file changed, 5 insertions(+), 4 deletions(-)
14f8ab
14f8ab
diff --git a/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t b/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
14f8ab
index 6351ba2..a1b9a85 100755
14f8ab
--- a/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
14f8ab
+++ b/tests/bugs/core/bug-1402841.t-mt-dir-scan-race.t
14f8ab
@@ -3,6 +3,8 @@
14f8ab
 . $(dirname $0)/../../volume.rc
14f8ab
 cleanup;
14f8ab
 
14f8ab
+FILE_COUNT=500
14f8ab
+
14f8ab
 TEST glusterd
14f8ab
 TEST pidof glusterd
14f8ab
 TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}{0,1}
14f8ab
@@ -11,15 +13,14 @@ TEST $CLI volume set $V0 cluster.shd-wait-qlength 100
14f8ab
 TEST $CLI volume start $V0
14f8ab
 
14f8ab
 TEST glusterfs --volfile-id=$V0 --volfile-server=$H0 $M0;
14f8ab
-touch $M0/file{1..200}
14f8ab
-
14f8ab
+for i in `seq 1 $FILE_COUNT`;  do touch $M0/file$i; done
14f8ab
 TEST kill_brick $V0 $H0 $B0/${V0}1
14f8ab
-for i in {1..200}; do echo hello>$M0/file$i; done
14f8ab
+for i in `seq 1 $FILE_COUNT`; do echo hello>$M0/file$i; chmod -x $M0/file$i; done
14f8ab
 TEST $CLI volume start $V0 force
14f8ab
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" brick_up_status $V0 $H0 $B0/${V0}1
14f8ab
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" afr_child_up_status $V0 1
14f8ab
 
14f8ab
-EXPECT "200" get_pending_heal_count $V0
14f8ab
+EXPECT "$FILE_COUNT" get_pending_heal_count $V0
14f8ab
 TEST $CLI volume set $V0 self-heal-daemon on
14f8ab
 
14f8ab
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "Y" glustershd_up_status
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab