14f8ab
From de31f2b0cb09a59941892c9981cb8a8b3aced9ec Mon Sep 17 00:00:00 2001
14f8ab
From: kshithijiyer <kshithij.ki@gmail.com>
14f8ab
Date: Tue, 24 Dec 2019 13:02:21 +0530
14f8ab
Subject: [PATCH 407/449] [geo-rep] Improving help message in
14f8ab
 schedule_georep.py.in
14f8ab
14f8ab
SLAVE positional argument doesn't provide a clear
14f8ab
picture of what it is when compared to mastervol and slavevol
14f8ab
in schedule_georep.py.in. It would be better if we change it to
14f8ab
something like "Slave hostame (<username>@SLAVEHOST or SLAVEHOST)"
14f8ab
14f8ab
Present:
14f8ab
----------
14f8ab
positional arguments:
14f8ab
  mastervol            Master Volume Name
14f8ab
  SLAVE                SLAVEHOST or root@SLAVEHOST or user@SLAVEHOST
14f8ab
  slavevol             Slave Volume Name
14f8ab
14f8ab
Suggested:
14f8ab
-----------
14f8ab
positional arguments:
14f8ab
  mastervol            Master Volume Name
14f8ab
  SLAVE                Slave hostname (<username>@SLAVEHOST or SLAVEHOST)
14f8ab
  slavevol             Slave Volume Name
14f8ab
14f8ab
Backport of:
14f8ab
    >Upstream Patch: https://review.gluster.org/#/c/glusterfs/+/23919/
14f8ab
    >fixes: bz#1786276
14f8ab
    >Change-Id: I73d52247997d623f77d55e51cbb6eccc08eb95ff
14f8ab
    >Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
14f8ab
14f8ab
BUG: 1787994
14f8ab
Change-Id: I73d52247997d623f77d55e51cbb6eccc08eb95ff
14f8ab
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
14f8ab
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/202454
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
14f8ab
---
14f8ab
 extras/geo-rep/schedule_georep.py.in | 4 ++--
14f8ab
 1 file changed, 2 insertions(+), 2 deletions(-)
14f8ab
14f8ab
diff --git a/extras/geo-rep/schedule_georep.py.in b/extras/geo-rep/schedule_georep.py.in
14f8ab
index f29ae02..ac93716 100644
14f8ab
--- a/extras/geo-rep/schedule_georep.py.in
14f8ab
+++ b/extras/geo-rep/schedule_georep.py.in
14f8ab
@@ -459,8 +459,8 @@ if __name__ == "__main__":
14f8ab
                             description=__doc__)
14f8ab
     parser.add_argument("mastervol", help="Master Volume Name")
14f8ab
     parser.add_argument("slave",
14f8ab
-                        help="SLAVEHOST or root@SLAVEHOST "
14f8ab
-                        "or user@SLAVEHOST",
14f8ab
+                        help="Slave hostname "
14f8ab
+                        "(<username>@SLAVEHOST or SLAVEHOST)",
14f8ab
                         metavar="SLAVE")
14f8ab
     parser.add_argument("slavevol", help="Slave Volume Name")
14f8ab
     parser.add_argument("--interval", help="Interval in Seconds. "
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab