|
 |
887953 |
From 331b648352fb0a2cce1ac671f24adf46b1b76b38 Mon Sep 17 00:00:00 2001
|
|
|
887953 |
From: Milind Changire <mchangir@redhat.com>
|
|
|
887953 |
Date: Tue, 23 Oct 2018 12:47:34 +0530
|
|
|
887953 |
Subject: [PATCH 405/406] glusterfsd: add missing UNLOCK
|
|
|
887953 |
|
|
|
887953 |
Reproducer steps: (by Sanju Rakonde)
|
|
|
887953 |
1. enable brick mux
|
|
|
887953 |
2. create 3 volumes
|
|
|
887953 |
3. start all the 3 volumes
|
|
|
887953 |
4. stop 1st volume, it will be success
|
|
|
887953 |
5. stop second volume, it will time out
|
|
|
887953 |
|
|
|
887953 |
Problem:
|
|
|
887953 |
Deadlock in glusterfs_handle_terminate() during volume stop of 2nd
|
|
|
887953 |
successive volume resulting in timeout at gluster CLI.
|
|
|
887953 |
|
|
|
887953 |
Solution:
|
|
|
887953 |
Add missing UNLOCK to xlator_mem_cleanup()
|
|
|
887953 |
|
|
|
887953 |
NOTE:
|
|
|
887953 |
Upstream code review by Kaushal Madappa has confirmed that the code is
|
|
|
887953 |
good at upstream. This needs to be a downstream only patch, however,
|
|
|
887953 |
this patch is not required at a rebase so will not be marking it as
|
|
|
887953 |
such.
|
|
|
887953 |
|
|
|
887953 |
Upstream patch: https://review.gluster.org/c/glusterfs/+/19734
|
|
|
887953 |
Downstream patch: https://code.engineering.redhat.com/gerrit/152908
|
|
|
887953 |
|
|
|
887953 |
BUG: 1641489
|
|
|
887953 |
Change-Id: I7281aa6f03edcb720f9eca3d274025166ff0b601
|
|
|
887953 |
Signed-off-by: Milind Changire <mchangir@redhat.com>
|
|
|
887953 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/153643
|
|
|
887953 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
887953 |
Reviewed-by: Kaushal Madappa <kaushal@redhat.com>
|
|
|
887953 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
887953 |
---
|
|
|
887953 |
glusterfsd/src/glusterfsd-mgmt.c | 1 +
|
|
|
887953 |
1 file changed, 1 insertion(+)
|
|
|
887953 |
|
|
|
887953 |
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
887953 |
index e3fceeb..b952526 100644
|
|
|
887953 |
--- a/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
887953 |
+++ b/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
887953 |
@@ -278,6 +278,7 @@ xlator_mem_cleanup (xlator_t *this) {
|
|
|
887953 |
break;
|
|
|
887953 |
}
|
|
|
887953 |
}
|
|
|
887953 |
+ UNLOCK (&ctx->volfile_lock);
|
|
|
887953 |
}
|
|
|
887953 |
}
|
|
|
887953 |
|
|
|
887953 |
--
|
|
|
887953 |
1.8.3.1
|
|
|
887953 |
|