9f5ccc
From f880df2ce4706dd748a09d3d6db57d49f62a234c Mon Sep 17 00:00:00 2001
9f5ccc
From: "Kaleb S. KEITHLEY" <kkeithle@redhat.com>
9f5ccc
Date: Thu, 28 May 2020 08:26:47 -0400
9f5ccc
Subject: [PATCH 383/383] common-ha: ganesha-ha.sh bad test for {rhel,centos}
9f5ccc
 for pcs options
9f5ccc
9f5ccc
bash [[ ... =~ ... ]] built-in returns _0_ when the regex matches,
9f5ccc
not 1, thus the sense of the test is backwards and never correctly
9f5ccc
detects rhel or centos.
9f5ccc
9f5ccc
https://review.gluster.org/#/c/glusterfs/+/24502/
9f5ccc
9f5ccc
Change-Id: Ic9e60aae4ea38aff8f13979080995e60621a68fe
9f5ccc
BUG: 1840794
9f5ccc
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
9f5ccc
Reviewed-on: https://code.engineering.redhat.com/gerrit/201686
9f5ccc
Tested-by: RHGS Build Bot <nigelb@redhat.com>
9f5ccc
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
9f5ccc
---
9f5ccc
 extras/ganesha/scripts/ganesha-ha.sh | 2 +-
9f5ccc
 1 file changed, 1 insertion(+), 1 deletion(-)
9f5ccc
9f5ccc
diff --git a/extras/ganesha/scripts/ganesha-ha.sh b/extras/ganesha/scripts/ganesha-ha.sh
9f5ccc
index 4ecf91b..a6814b1 100644
9f5ccc
--- a/extras/ganesha/scripts/ganesha-ha.sh
9f5ccc
+++ b/extras/ganesha/scripts/ganesha-ha.sh
9f5ccc
@@ -1054,7 +1054,7 @@ main()
9f5ccc
         # Fedora 29+ and rhel/centos 8 has PCS-0.10.x
9f5ccc
         # default is pcs-0.10.x options but check for
9f5ccc
         # rhel/centos 7 (pcs-0.9.x) and adjust accordingly
9f5ccc
-        if [[ ${ID} =~ {rhel,centos} ]]; then
9f5ccc
+        if [[ ! ${ID} =~ {rhel,centos} ]]; then
9f5ccc
             if [[ ${VERSION_ID} == 7.* ]]; then
9f5ccc
                 PCS9OR10_PCS_CNAME_OPTION="--name"
9f5ccc
                 PCS9OR10_PCS_CLONE_OPTION="--clone"
9f5ccc
-- 
9f5ccc
1.8.3.1
9f5ccc