|
 |
d1681e |
From b55e9f05cb457806d08ac184de4b5651e420f11e Mon Sep 17 00:00:00 2001
|
|
|
d1681e |
From: Mohit Agrawal <moagrawal@redhat.com>
|
|
|
d1681e |
Date: Mon, 27 Aug 2018 12:18:21 +0530
|
|
|
d1681e |
Subject: [PATCH 362/362] glusterd: glusterd_brick_start shouldn't cleanup
|
|
|
d1681e |
pidfile if only_connect is true
|
|
|
d1681e |
|
|
|
d1681e |
Problem: Sometime glusterd cleanup pidfile even brick is started
|
|
|
d1681e |
and cli shows volume status "N/A"
|
|
|
d1681e |
|
|
|
d1681e |
Solution: Update the condition in glusterd_brick_start to avoid
|
|
|
d1681e |
pidfile cleanup in case if only_connect flag is true
|
|
|
d1681e |
|
|
|
d1681e |
> Fixes: bz#1622422
|
|
|
d1681e |
> Change-Id: I8decb34597126b848e3a44d957e138833dd97350
|
|
|
d1681e |
> (cherry picked from commit 1b499e9dfe63ce051a071cacc19e3161b7a32636)
|
|
|
d1681e |
> (Reviewed on upstream link https://review.gluster.org/#/c/glusterfs/+/21007/)
|
|
|
d1681e |
|
|
|
d1681e |
Change-Id: Id9145c26de15cf2354a10a482b5f8a45599e0831
|
|
|
d1681e |
BUG: 1622452
|
|
|
d1681e |
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
|
|
|
d1681e |
Reviewed-on: https://code.engineering.redhat.com/gerrit/148184
|
|
|
d1681e |
Tested-by: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
d1681e |
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
d1681e |
---
|
|
|
d1681e |
xlators/mgmt/glusterd/src/glusterd-utils.c | 8 ++++----
|
|
|
d1681e |
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
d1681e |
|
|
|
d1681e |
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
|
|
|
d1681e |
index b9e8d8d..01345cd 100644
|
|
|
d1681e |
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
|
|
|
d1681e |
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
|
|
|
d1681e |
@@ -6163,6 +6163,8 @@ glusterd_brick_start (glusterd_volinfo_t *volinfo,
|
|
|
d1681e |
brickpath = search_brick_path_from_proc
|
|
|
d1681e |
(pid, brickinfo->path);
|
|
|
d1681e |
if (!brickpath) {
|
|
|
d1681e |
+ if (only_connect)
|
|
|
d1681e |
+ return 0;
|
|
|
d1681e |
gf_log (this->name, GF_LOG_INFO,
|
|
|
d1681e |
"Either pid %d is not running or brick"
|
|
|
d1681e |
" path %s is not consumed so cleanup pidfile",
|
|
|
d1681e |
@@ -6173,14 +6175,14 @@ glusterd_brick_start (glusterd_volinfo_t *volinfo,
|
|
|
d1681e |
if (sys_access (pidfile , R_OK) == 0) {
|
|
|
d1681e |
sys_unlink (pidfile);
|
|
|
d1681e |
}
|
|
|
d1681e |
- if (only_connect)
|
|
|
d1681e |
- return 0;
|
|
|
d1681e |
goto run;
|
|
|
d1681e |
}
|
|
|
d1681e |
GF_FREE (brickpath);
|
|
|
d1681e |
ret = glusterd_get_sock_from_brick_pid (pid, socketpath,
|
|
|
d1681e |
sizeof(socketpath));
|
|
|
d1681e |
if (ret) {
|
|
|
d1681e |
+ if (only_connect)
|
|
|
d1681e |
+ return 0;
|
|
|
d1681e |
gf_log (this->name, GF_LOG_INFO,
|
|
|
d1681e |
"Either pid %d is not running or does "
|
|
|
d1681e |
"not match with any running brick "
|
|
|
d1681e |
@@ -6189,8 +6191,6 @@ glusterd_brick_start (glusterd_volinfo_t *volinfo,
|
|
|
d1681e |
if (sys_access (pidfile , R_OK) == 0) {
|
|
|
d1681e |
sys_unlink (pidfile);
|
|
|
d1681e |
}
|
|
|
d1681e |
- if (only_connect)
|
|
|
d1681e |
- return 0;
|
|
|
d1681e |
goto run;
|
|
|
d1681e |
}
|
|
|
d1681e |
}
|
|
|
d1681e |
--
|
|
|
d1681e |
1.8.3.1
|
|
|
d1681e |
|