9f5ccc
From c0efaa98d777e4520028bf55482846b3ef5fca3a Mon Sep 17 00:00:00 2001
9f5ccc
From: Susant Palai <spalai@redhat.com>
9f5ccc
Date: Wed, 1 Apr 2020 12:14:31 +0530
9f5ccc
Subject: [PATCH 359/362] dht: gf_defrag_process_dir is called even if
9f5ccc
 gf_defrag_fix_layout has failed
9f5ccc
9f5ccc
Currently even though gf_defrag_fix_layout fails with ENOENT or ESTALE, a
9f5ccc
subsequent call is made to gf_defrag_process_dir leading to rebalance failure.
9f5ccc
9f5ccc
upstream patch: https://review.gluster.org/#/c/glusterfs/+/24225
9f5ccc
9f5ccc
> fixes: #1102
9f5ccc
> Change-Id: Ib0c309fd78e89a000fed3feb4bbe2c5b48e61478
9f5ccc
> Signed-off-by: Susant Palai <spalai@redhat.com>
9f5ccc
9f5ccc
BUG: 1812789
9f5ccc
Change-Id: Ib0c309fd78e89a000fed3feb4bbe2c5b48e61478
9f5ccc
Signed-off-by: Susant Palai <spalai@redhat.com>
9f5ccc
Reviewed-on: https://code.engineering.redhat.com/gerrit/196249
9f5ccc
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
9f5ccc
Tested-by: RHGS Build Bot <nigelb@redhat.com>
9f5ccc
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
9f5ccc
---
9f5ccc
 xlators/cluster/dht/src/dht-rebalance.c | 1 +
9f5ccc
 1 file changed, 1 insertion(+)
9f5ccc
9f5ccc
diff --git a/xlators/cluster/dht/src/dht-rebalance.c b/xlators/cluster/dht/src/dht-rebalance.c
9f5ccc
index 559f046..f4c62b8 100644
9f5ccc
--- a/xlators/cluster/dht/src/dht-rebalance.c
9f5ccc
+++ b/xlators/cluster/dht/src/dht-rebalance.c
9f5ccc
@@ -3939,6 +3939,7 @@ gf_defrag_fix_layout(xlator_t *this, gf_defrag_info_t *defrag, loc_t *loc,
9f5ccc
                 defrag->total_failures++;
9f5ccc
             }
9f5ccc
             ret = 0;
9f5ccc
+            goto out;
9f5ccc
         } else {
9f5ccc
             gf_msg(this->name, GF_LOG_ERROR, -ret, DHT_MSG_LAYOUT_FIX_FAILED,
9f5ccc
                    "Setxattr failed for %s", loc->path);
9f5ccc
-- 
9f5ccc
1.8.3.1
9f5ccc