21ab4e
From 50c7c78e8e70396cf7da8f3cf05a2814b2953926 Mon Sep 17 00:00:00 2001
21ab4e
From: Atin Mukherjee <amukherj@redhat.com>
21ab4e
Date: Tue, 21 Feb 2017 18:33:14 +0530
21ab4e
Subject: [PATCH 337/361] glusterd: unref brickinfo object on volume stop
21ab4e
21ab4e
If brick multiplexing is enabled, on a volume stop glusterd was not
21ab4e
unrefing the brickinfo rpc object which lead to a flood of stale rpc
21ab4e
logs.
21ab4e
21ab4e
mainline:
21ab4e
> BUG: 1421724
21ab4e
> Reviewed-on: https://review.gluster.org/16699
21ab4e
> Smoke: Gluster Build System <jenkins@build.gluster.org>
21ab4e
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
21ab4e
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
21ab4e
> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
21ab4e
> Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
21ab4e
(cherry picked from commit 16b342a7536e67f30b11258849cae8f9459bc518)
21ab4e
21ab4e
BUG: 1417815
21ab4e
Change-Id: I18fedcd6921042ef2e945605466194b7b53fe2f7
21ab4e
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
21ab4e
Reviewed-on: https://code.engineering.redhat.com/gerrit/101318
21ab4e
Tested-by: Milind Changire <mchangir@redhat.com>
21ab4e
---
21ab4e
 xlators/mgmt/glusterd/src/glusterd-utils.c | 2 +-
21ab4e
 1 file changed, 1 insertion(+), 1 deletion(-)
21ab4e
21ab4e
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
21ab4e
index 66b3d54..42887e9 100644
21ab4e
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
21ab4e
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
21ab4e
@@ -2105,8 +2105,8 @@ glusterd_volume_stop_glusterfs (glusterd_volinfo_t  *volinfo,
21ab4e
                         if (op_errstr) {
21ab4e
                                 GF_FREE (op_errstr);
21ab4e
                         }
21ab4e
-                        (void) glusterd_brick_disconnect (brickinfo);
21ab4e
                 }
21ab4e
+                (void) glusterd_brick_disconnect (brickinfo);
21ab4e
                 ret = 0;
21ab4e
         }
21ab4e
 
21ab4e
-- 
21ab4e
1.8.3.1
21ab4e