74b1de
From 808f311bd4f38f06b8afc49fc8d2c65fc4797431 Mon Sep 17 00:00:00 2001
74b1de
From: kshithijiyer <kshithij.ki@gmail.com>
74b1de
Date: Fri, 28 Jun 2019 15:32:31 +0530
74b1de
Subject: [PATCH 332/335] Removing one top command from gluster v help
74b1de
74b1de
The current help show 2 different top commands
74b1de
intead of one single top command which can be
74b1de
easily observed when "# gluster v help" command
74b1de
is issued. Removing one "volume top <VOLNAME>"
74b1de
and clubbing into them into a single command.
74b1de
74b1de
Current help:
74b1de
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
74b1de
[nfs|brick <brick>] [list-cnt <value>] |
74b1de
volume top <VOLNAME> {read-perf|write-perf}
74b1de
[bs <size> count <count>] [brick <brick>]
74b1de
[list-cnt <value>] - volume top operations
74b1de
74b1de
Expected help:
74b1de
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
74b1de
[nfs|brick <brick>] [list-cnt <value>] | {read-perf|write-perf}
74b1de
[bs <size> count <count>] [brick <brick>] [list-cnt <value>]
74b1de
- volume top operations
74b1de
74b1de
> upstream patch: https://review.gluster.org/#/c/glusterfs/+/22972/
74b1de
> fixes: bz#1725034
74b1de
> Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
74b1de
> Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
74b1de
74b1de
BUG: 1726058
74b1de
Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
74b1de
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/185757
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74b1de
---
74b1de
 cli/src/cli-cmd-volume.c | 4 ++--
74b1de
 1 file changed, 2 insertions(+), 2 deletions(-)
74b1de
74b1de
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c
74b1de
index 66beb1b..754d333 100644
74b1de
--- a/cli/src/cli-cmd-volume.c
74b1de
+++ b/cli/src/cli-cmd-volume.c
74b1de
@@ -3427,8 +3427,8 @@ struct cli_cmd volume_cmds[] = {
74b1de
      cli_cmd_volume_profile_cbk, "volume profile operations"},
74b1de
 
74b1de
     {"volume top <VOLNAME> {open|read|write|opendir|readdir|clear} [nfs|brick "
74b1de
-     "<brick>] [list-cnt <value>] |\n"
74b1de
-     "volume top <VOLNAME> {read-perf|write-perf} [bs <size> count <count>] "
74b1de
+     "<brick>] [list-cnt <value>] | "
74b1de
+     "{read-perf|write-perf} [bs <size> count <count>] "
74b1de
      "[brick <brick>] [list-cnt <value>]",
74b1de
      cli_cmd_volume_top_cbk, "volume top operations"},
74b1de
 
74b1de
-- 
74b1de
1.8.3.1
74b1de