17b94a
From 808f311bd4f38f06b8afc49fc8d2c65fc4797431 Mon Sep 17 00:00:00 2001
17b94a
From: kshithijiyer <kshithij.ki@gmail.com>
17b94a
Date: Fri, 28 Jun 2019 15:32:31 +0530
17b94a
Subject: [PATCH 332/335] Removing one top command from gluster v help
17b94a
17b94a
The current help show 2 different top commands
17b94a
intead of one single top command which can be
17b94a
easily observed when "# gluster v help" command
17b94a
is issued. Removing one "volume top <VOLNAME>"
17b94a
and clubbing into them into a single command.
17b94a
17b94a
Current help:
17b94a
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
17b94a
[nfs|brick <brick>] [list-cnt <value>] |
17b94a
volume top <VOLNAME> {read-perf|write-perf}
17b94a
[bs <size> count <count>] [brick <brick>]
17b94a
[list-cnt <value>] - volume top operations
17b94a
17b94a
Expected help:
17b94a
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
17b94a
[nfs|brick <brick>] [list-cnt <value>] | {read-perf|write-perf}
17b94a
[bs <size> count <count>] [brick <brick>] [list-cnt <value>]
17b94a
- volume top operations
17b94a
17b94a
> upstream patch: https://review.gluster.org/#/c/glusterfs/+/22972/
17b94a
> fixes: bz#1725034
17b94a
> Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
17b94a
> Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
17b94a
17b94a
BUG: 1726058
17b94a
Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
17b94a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/185757
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
17b94a
---
17b94a
 cli/src/cli-cmd-volume.c | 4 ++--
17b94a
 1 file changed, 2 insertions(+), 2 deletions(-)
17b94a
17b94a
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c
17b94a
index 66beb1b..754d333 100644
17b94a
--- a/cli/src/cli-cmd-volume.c
17b94a
+++ b/cli/src/cli-cmd-volume.c
17b94a
@@ -3427,8 +3427,8 @@ struct cli_cmd volume_cmds[] = {
17b94a
      cli_cmd_volume_profile_cbk, "volume profile operations"},
17b94a
 
17b94a
     {"volume top <VOLNAME> {open|read|write|opendir|readdir|clear} [nfs|brick "
17b94a
-     "<brick>] [list-cnt <value>] |\n"
17b94a
-     "volume top <VOLNAME> {read-perf|write-perf} [bs <size> count <count>] "
17b94a
+     "<brick>] [list-cnt <value>] | "
17b94a
+     "{read-perf|write-perf} [bs <size> count <count>] "
17b94a
      "[brick <brick>] [list-cnt <value>]",
17b94a
      cli_cmd_volume_top_cbk, "volume top operations"},
17b94a
 
17b94a
-- 
17b94a
1.8.3.1
17b94a