9f5ccc
From 808f311bd4f38f06b8afc49fc8d2c65fc4797431 Mon Sep 17 00:00:00 2001
9f5ccc
From: kshithijiyer <kshithij.ki@gmail.com>
9f5ccc
Date: Fri, 28 Jun 2019 15:32:31 +0530
9f5ccc
Subject: [PATCH 332/335] Removing one top command from gluster v help
9f5ccc
9f5ccc
The current help show 2 different top commands
9f5ccc
intead of one single top command which can be
9f5ccc
easily observed when "# gluster v help" command
9f5ccc
is issued. Removing one "volume top <VOLNAME>"
9f5ccc
and clubbing into them into a single command.
9f5ccc
9f5ccc
Current help:
9f5ccc
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
9f5ccc
[nfs|brick <brick>] [list-cnt <value>] |
9f5ccc
volume top <VOLNAME> {read-perf|write-perf}
9f5ccc
[bs <size> count <count>] [brick <brick>]
9f5ccc
[list-cnt <value>] - volume top operations
9f5ccc
9f5ccc
Expected help:
9f5ccc
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
9f5ccc
[nfs|brick <brick>] [list-cnt <value>] | {read-perf|write-perf}
9f5ccc
[bs <size> count <count>] [brick <brick>] [list-cnt <value>]
9f5ccc
- volume top operations
9f5ccc
9f5ccc
> upstream patch: https://review.gluster.org/#/c/glusterfs/+/22972/
9f5ccc
> fixes: bz#1725034
9f5ccc
> Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
9f5ccc
> Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
9f5ccc
9f5ccc
BUG: 1726058
9f5ccc
Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
9f5ccc
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
9f5ccc
Reviewed-on: https://code.engineering.redhat.com/gerrit/185757
9f5ccc
Tested-by: RHGS Build Bot <nigelb@redhat.com>
9f5ccc
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
9f5ccc
---
9f5ccc
 cli/src/cli-cmd-volume.c | 4 ++--
9f5ccc
 1 file changed, 2 insertions(+), 2 deletions(-)
9f5ccc
9f5ccc
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c
9f5ccc
index 66beb1b..754d333 100644
9f5ccc
--- a/cli/src/cli-cmd-volume.c
9f5ccc
+++ b/cli/src/cli-cmd-volume.c
9f5ccc
@@ -3427,8 +3427,8 @@ struct cli_cmd volume_cmds[] = {
9f5ccc
      cli_cmd_volume_profile_cbk, "volume profile operations"},
9f5ccc
 
9f5ccc
     {"volume top <VOLNAME> {open|read|write|opendir|readdir|clear} [nfs|brick "
9f5ccc
-     "<brick>] [list-cnt <value>] |\n"
9f5ccc
-     "volume top <VOLNAME> {read-perf|write-perf} [bs <size> count <count>] "
9f5ccc
+     "<brick>] [list-cnt <value>] | "
9f5ccc
+     "{read-perf|write-perf} [bs <size> count <count>] "
9f5ccc
      "[brick <brick>] [list-cnt <value>]",
9f5ccc
      cli_cmd_volume_top_cbk, "volume top operations"},
9f5ccc
 
9f5ccc
-- 
9f5ccc
1.8.3.1
9f5ccc