74b1de
From b1d8a5ee8b2e320aaaf9b2a145fbc285178d07bb Mon Sep 17 00:00:00 2001
74b1de
From: hari gowtham <hgowtham@redhat.com>
74b1de
Date: Tue, 22 Oct 2019 15:11:03 +0530
74b1de
Subject: [PATCH 312/313] Scripts: quota_fsck script KeyError: 'contri_size'
74b1de
74b1de
    back-port of: https://review.gluster.org/#/c/glusterfs/+/23586/
74b1de
74b1de
Problem: In a certain code flow, we weren't handling the
74b1de
unavailability of the contri value in the dict. Trying to print
74b1de
without the value resulted in erroring out.
74b1de
74b1de
Fix: Have printed the whole of dictionary as the values will be
74b1de
helpful in understanding the state of the file/dir
74b1de
74b1de
>Fixes: bz#1764129
74b1de
>Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725
74b1de
>Signed-off-by: hari gowtham <hgowtham@redhat.com>
74b1de
74b1de
BUG: 1719171
74b1de
Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725
74b1de
Signed-off-by: hari gowtham <hgowtham@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/183720
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74b1de
---
74b1de
 extras/quota/quota_fsck.py | 12 ++++++------
74b1de
 1 file changed, 6 insertions(+), 6 deletions(-)
74b1de
74b1de
diff --git a/extras/quota/quota_fsck.py b/extras/quota/quota_fsck.py
74b1de
index f03895d..485a37a 100755
74b1de
--- a/extras/quota/quota_fsck.py
74b1de
+++ b/extras/quota/quota_fsck.py
74b1de
@@ -52,17 +52,17 @@ epilog_msg='''
74b1de
 
74b1de
 def print_msg(log_type, path, xattr_dict = {}, stbuf = "", dir_size = None):
74b1de
     if log_type == QUOTA_VERBOSE:
74b1de
-        print('%-24s %-60s\nxattr_values: %s\n%s\n' % {"Verbose", path,  xattr_dict, stbuf})
74b1de
+        print('%-24s %-60s\nxattr_values: %s\n%s\n' % ("Verbose", path, xattr_dict, stbuf))
74b1de
     elif log_type == QUOTA_META_ABSENT:
74b1de
-        print('%-24s %-60s\n%s\n' % {"Quota-Meta Absent", path, xattr_dict})
74b1de
+        print('%-24s %-60s\n%s\n' % ("Quota-Meta Absent", path, xattr_dict))
74b1de
     elif log_type == QUOTA_SIZE_MISMATCH:
74b1de
         print("mismatch")
74b1de
         if dir_size is not None:
74b1de
-            print('%24s %60s %12s %12s' % {"Size Mismatch", path, xattr_dict['contri_size'],
74b1de
-                   dir_size})
74b1de
+            print('%24s %60s %12s %12s' % ("Size Mismatch", path, 
74b1de
+                xattr_dict, dir_size))
74b1de
         else:
74b1de
-            print('%-24s %-60s %-12i %-12i' % {"Size Mismatch", path, xattr_dict['contri_size'],
74b1de
-                   stbuf.st_size})
74b1de
+            print('%-24s %-60s %-12i %-12i' % ("Size Mismatch", path, xattr_dict,
74b1de
+                   stbuf.st_size))
74b1de
 
74b1de
 def size_differs_lot(s1, s2):
74b1de
     '''
74b1de
-- 
74b1de
1.8.3.1
74b1de