14f8ab
From b1d8a5ee8b2e320aaaf9b2a145fbc285178d07bb Mon Sep 17 00:00:00 2001
14f8ab
From: hari gowtham <hgowtham@redhat.com>
14f8ab
Date: Tue, 22 Oct 2019 15:11:03 +0530
14f8ab
Subject: [PATCH 312/313] Scripts: quota_fsck script KeyError: 'contri_size'
14f8ab
14f8ab
    back-port of: https://review.gluster.org/#/c/glusterfs/+/23586/
14f8ab
14f8ab
Problem: In a certain code flow, we weren't handling the
14f8ab
unavailability of the contri value in the dict. Trying to print
14f8ab
without the value resulted in erroring out.
14f8ab
14f8ab
Fix: Have printed the whole of dictionary as the values will be
14f8ab
helpful in understanding the state of the file/dir
14f8ab
14f8ab
>Fixes: bz#1764129
14f8ab
>Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725
14f8ab
>Signed-off-by: hari gowtham <hgowtham@redhat.com>
14f8ab
14f8ab
BUG: 1719171
14f8ab
Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725
14f8ab
Signed-off-by: hari gowtham <hgowtham@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/183720
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
14f8ab
---
14f8ab
 extras/quota/quota_fsck.py | 12 ++++++------
14f8ab
 1 file changed, 6 insertions(+), 6 deletions(-)
14f8ab
14f8ab
diff --git a/extras/quota/quota_fsck.py b/extras/quota/quota_fsck.py
14f8ab
index f03895d..485a37a 100755
14f8ab
--- a/extras/quota/quota_fsck.py
14f8ab
+++ b/extras/quota/quota_fsck.py
14f8ab
@@ -52,17 +52,17 @@ epilog_msg='''
14f8ab
 
14f8ab
 def print_msg(log_type, path, xattr_dict = {}, stbuf = "", dir_size = None):
14f8ab
     if log_type == QUOTA_VERBOSE:
14f8ab
-        print('%-24s %-60s\nxattr_values: %s\n%s\n' % {"Verbose", path,  xattr_dict, stbuf})
14f8ab
+        print('%-24s %-60s\nxattr_values: %s\n%s\n' % ("Verbose", path, xattr_dict, stbuf))
14f8ab
     elif log_type == QUOTA_META_ABSENT:
14f8ab
-        print('%-24s %-60s\n%s\n' % {"Quota-Meta Absent", path, xattr_dict})
14f8ab
+        print('%-24s %-60s\n%s\n' % ("Quota-Meta Absent", path, xattr_dict))
14f8ab
     elif log_type == QUOTA_SIZE_MISMATCH:
14f8ab
         print("mismatch")
14f8ab
         if dir_size is not None:
14f8ab
-            print('%24s %60s %12s %12s' % {"Size Mismatch", path, xattr_dict['contri_size'],
14f8ab
-                   dir_size})
14f8ab
+            print('%24s %60s %12s %12s' % ("Size Mismatch", path, 
14f8ab
+                xattr_dict, dir_size))
14f8ab
         else:
14f8ab
-            print('%-24s %-60s %-12i %-12i' % {"Size Mismatch", path, xattr_dict['contri_size'],
14f8ab
-                   stbuf.st_size})
14f8ab
+            print('%-24s %-60s %-12i %-12i' % ("Size Mismatch", path, xattr_dict,
14f8ab
+                   stbuf.st_size))
14f8ab
 
14f8ab
 def size_differs_lot(s1, s2):
14f8ab
     '''
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab