|
 |
a3470f |
From 4d1636273b5333ed88ffd051c365490c73a380da Mon Sep 17 00:00:00 2001
|
|
|
a3470f |
From: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
a3470f |
Date: Tue, 26 Jun 2018 15:58:02 +0530
|
|
|
a3470f |
Subject: [PATCH 301/305] storage/posix: Fix posix_symlinks_match()
|
|
|
a3470f |
|
|
|
a3470f |
Upstream patch: https://review.gluster.org/20399
|
|
|
a3470f |
|
|
|
a3470f |
1) snprintf into linkname_expected should happen with PATH_MAX
|
|
|
a3470f |
2) comparison should happen with linkname_actual with complete
|
|
|
a3470f |
string linkname_expected
|
|
|
a3470f |
|
|
|
a3470f |
BUG: 1558989
|
|
|
a3470f |
Change-Id: Ic3b3c362dc6c69c046b9a13e031989be47ecff14
|
|
|
a3470f |
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
a3470f |
Reviewed-on: https://code.engineering.redhat.com/gerrit/142486
|
|
|
a3470f |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
a3470f |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
a3470f |
---
|
|
|
a3470f |
tests/bugs/replicate/bug-1477169-entry-selfheal-rename.t | 15 ++++++++++-----
|
|
|
a3470f |
xlators/storage/posix/src/posix.c | 16 +++++++++++++---
|
|
|
a3470f |
2 files changed, 23 insertions(+), 8 deletions(-)
|
|
|
a3470f |
|
|
|
a3470f |
diff --git a/tests/bugs/replicate/bug-1477169-entry-selfheal-rename.t b/tests/bugs/replicate/bug-1477169-entry-selfheal-rename.t
|
|
|
a3470f |
index 465800b..bb858a8 100644
|
|
|
a3470f |
--- a/tests/bugs/replicate/bug-1477169-entry-selfheal-rename.t
|
|
|
a3470f |
+++ b/tests/bugs/replicate/bug-1477169-entry-selfheal-rename.t
|
|
|
a3470f |
@@ -13,10 +13,10 @@ EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status $V0 0
|
|
|
a3470f |
EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status $V0 1
|
|
|
a3470f |
EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status $V0 2
|
|
|
a3470f |
|
|
|
a3470f |
-TEST mkdir -p $M0/d1/dir $M0/d2
|
|
|
a3470f |
+TEST mkdir -p $M0/d1/dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 $M0/d2
|
|
|
a3470f |
gfid_d1=$(gf_get_gfid_xattr $B0/${V0}0/d1)
|
|
|
a3470f |
gfid_d2=$(gf_get_gfid_xattr $B0/${V0}0/d2)
|
|
|
a3470f |
-gfid_dir=$(gf_get_gfid_xattr $B0/${V0}0/d1/dir)
|
|
|
a3470f |
+gfid_dir=$(gf_get_gfid_xattr $B0/${V0}0/d1/dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789)
|
|
|
a3470f |
|
|
|
a3470f |
gfid_str_d1=$(gf_gfid_xattr_to_str $gfid_d1)
|
|
|
a3470f |
gfid_str_d2=$(gf_gfid_xattr_to_str $gfid_d2)
|
|
|
a3470f |
@@ -24,7 +24,7 @@ gfid_str_d3=$(gf_gfid_xattr_to_str $gfid_dir)
|
|
|
a3470f |
|
|
|
a3470f |
# Kill 3rd brick and rename the dir from mount.
|
|
|
a3470f |
TEST kill_brick $V0 $H0 $B0/${V0}2
|
|
|
a3470f |
-TEST mv $M0/d1/dir $M0/d2
|
|
|
a3470f |
+TEST mv $M0/d1/dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 $M0/d2
|
|
|
a3470f |
|
|
|
a3470f |
# Bring it back and trigger heal.
|
|
|
a3470f |
TEST $CLI volume start $V0 force
|
|
|
a3470f |
@@ -38,10 +38,15 @@ EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 2
|
|
|
a3470f |
TEST $CLI volume heal $V0
|
|
|
a3470f |
EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0
|
|
|
a3470f |
|
|
|
a3470f |
-# Check that .glusterfs symlink for dir exists and points to d2/dir
|
|
|
a3470f |
+# Check that .glusterfs symlink for dir exists and points to d2/dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
|
|
|
a3470f |
TEST linkname=$(readlink $B0/${V0}2/.glusterfs/${gfid_str_d3:0:2}/${gfid_str_d3:2:2}/$gfid_str_d3)
|
|
|
a3470f |
-EXPECT "dir" basename $linkname
|
|
|
a3470f |
+EXPECT "dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789" basename $linkname
|
|
|
a3470f |
TEST parent_dir_gfid_str=$(echo $linkname|cut -d / -f5)
|
|
|
a3470f |
EXPECT $gfid_str_d2 echo $parent_dir_gfid_str
|
|
|
a3470f |
|
|
|
a3470f |
+TEST rmdir $M0/d2/dir012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
|
|
|
a3470f |
+
|
|
|
a3470f |
+TEST ! stat $B0/${V0}0/.glusterfs/${gfid_str_d3:0:2}/${gfid_str_d3:2:2}/$gfid_str_d3
|
|
|
a3470f |
+TEST ! stat $B0/${V0}1/.glusterfs/${gfid_str_d3:0:2}/${gfid_str_d3:2:2}/$gfid_str_d3
|
|
|
a3470f |
+TEST ! stat $B0/${V0}2/.glusterfs/${gfid_str_d3:0:2}/${gfid_str_d3:2:2}/$gfid_str_d3
|
|
|
a3470f |
cleanup;
|
|
|
a3470f |
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c
|
|
|
a3470f |
index 6aa64f9..af54882 100644
|
|
|
a3470f |
--- a/xlators/storage/posix/src/posix.c
|
|
|
a3470f |
+++ b/xlators/storage/posix/src/posix.c
|
|
|
a3470f |
@@ -125,17 +125,27 @@ posix_symlinks_match (xlator_t *this, loc_t *loc, uuid_t gfid)
|
|
|
a3470f |
handle_size = POSIX_GFID_HANDLE_SIZE(priv->base_path_length);
|
|
|
a3470f |
dir_handle = alloca0 (handle_size);
|
|
|
a3470f |
|
|
|
a3470f |
- snprintf (linkname_expected, handle_size, "../../%02x/%02x/%s/%s",
|
|
|
a3470f |
+ snprintf (linkname_expected, PATH_MAX, "../../%02x/%02x/%s/%s",
|
|
|
a3470f |
loc->pargfid[0], loc->pargfid[1], uuid_utoa (loc->pargfid),
|
|
|
a3470f |
loc->name);
|
|
|
a3470f |
|
|
|
a3470f |
MAKE_HANDLE_GFID_PATH (dir_handle, this, gfid, NULL);
|
|
|
a3470f |
len = sys_readlink (dir_handle, linkname_actual, PATH_MAX);
|
|
|
a3470f |
- if (len < 0)
|
|
|
a3470f |
+ if (len < 0 || len == PATH_MAX) {
|
|
|
a3470f |
+ if (len == PATH_MAX) {
|
|
|
a3470f |
+ errno = EINVAL;
|
|
|
a3470f |
+ }
|
|
|
a3470f |
+
|
|
|
a3470f |
+ if (errno != ENOENT) {
|
|
|
a3470f |
+ gf_msg (this->name, GF_LOG_ERROR, errno,
|
|
|
a3470f |
+ P_MSG_LSTAT_FAILED, "readlink[%s] failed",
|
|
|
a3470f |
+ dir_handle);
|
|
|
a3470f |
+ }
|
|
|
a3470f |
goto out;
|
|
|
a3470f |
+ }
|
|
|
a3470f |
linkname_actual[len] = '\0';
|
|
|
a3470f |
|
|
|
a3470f |
- if (!strncmp (linkname_actual, linkname_expected, handle_size))
|
|
|
a3470f |
+ if (!strcmp (linkname_actual, linkname_expected))
|
|
|
a3470f |
ret = _gf_true;
|
|
|
a3470f |
|
|
|
a3470f |
out:
|
|
|
a3470f |
--
|
|
|
a3470f |
1.8.3.1
|
|
|
a3470f |
|