|
 |
ca3909 |
From 8f89aef9691b0806d7487525c6a54a1a615c8bc1 Mon Sep 17 00:00:00 2001
|
|
|
ca3909 |
From: Mohit Agrawal <moagrawal@redhat.com>
|
|
|
ca3909 |
Date: Mon, 2 Sep 2019 10:46:10 +0530
|
|
|
ca3909 |
Subject: [PATCH 293/297] glusterd: IPV6 hostname address is not parsed
|
|
|
ca3909 |
correctly
|
|
|
ca3909 |
|
|
|
ca3909 |
Problem: IPV6 hostname address is not parsed correctly in function
|
|
|
ca3909 |
glusterd_check_brick_order
|
|
|
ca3909 |
|
|
|
ca3909 |
Solution: Update the code to parse hostname address
|
|
|
ca3909 |
|
|
|
ca3909 |
> Change-Id: Ifb2f83f9c6e987b2292070e048e97eeb51b728ab
|
|
|
ca3909 |
> Fixes: bz#1747746
|
|
|
ca3909 |
> Credits: Amgad Saleh <amgad.saleh@nokia.com>
|
|
|
ca3909 |
> Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
|
|
|
ca3909 |
> (Cherry picked from commit 6563ffb04d7ba51a89726e7c5bbb85c7dbc685b5)
|
|
|
ca3909 |
> (Reviewed on upstream link https://review.gluster.org/#/c/glusterfs/+/23341/)
|
|
|
ca3909 |
|
|
|
ca3909 |
Change-Id: Ifb2f83f9c6e987b2292070e048e97eeb51b728ab
|
|
|
ca3909 |
BUG: 1750241
|
|
|
ca3909 |
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
ca3909 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/181185
|
|
|
ca3909 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
ca3909 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
ca3909 |
---
|
|
|
ca3909 |
xlators/mgmt/glusterd/src/glusterd-volume-ops.c | 16 +++++++++++-----
|
|
|
ca3909 |
1 file changed, 11 insertions(+), 5 deletions(-)
|
|
|
ca3909 |
|
|
|
ca3909 |
diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
|
|
|
ca3909 |
index 1ea8ba6..076bc80 100644
|
|
|
ca3909 |
--- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
|
|
|
ca3909 |
+++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
|
|
|
ca3909 |
@@ -95,6 +95,10 @@ glusterd_check_brick_order(dict_t *dict, char *err_str)
|
|
|
ca3909 |
int32_t type = GF_CLUSTER_TYPE_NONE;
|
|
|
ca3909 |
int32_t sub_count = 0;
|
|
|
ca3909 |
struct addrinfo *ai_info = NULL;
|
|
|
ca3909 |
+ char brick_addr[128] = {
|
|
|
ca3909 |
+ 0,
|
|
|
ca3909 |
+ };
|
|
|
ca3909 |
+ int addrlen = 0;
|
|
|
ca3909 |
|
|
|
ca3909 |
const char failed_string[2048] =
|
|
|
ca3909 |
"Failed to perform brick order "
|
|
|
ca3909 |
@@ -182,15 +186,17 @@ glusterd_check_brick_order(dict_t *dict, char *err_str)
|
|
|
ca3909 |
brick_list_dup = tmpptr;
|
|
|
ca3909 |
if (brick == NULL)
|
|
|
ca3909 |
goto check_failed;
|
|
|
ca3909 |
- brick = strtok_r(brick, ":", &tmpptr);
|
|
|
ca3909 |
- if (brick == NULL)
|
|
|
ca3909 |
+ tmpptr = strrchr(brick, ':');
|
|
|
ca3909 |
+ if (tmpptr == NULL)
|
|
|
ca3909 |
goto check_failed;
|
|
|
ca3909 |
- ret = getaddrinfo(brick, NULL, NULL, &ai_info);
|
|
|
ca3909 |
+ addrlen = strlen(brick) - strlen(tmpptr);
|
|
|
ca3909 |
+ strncpy(brick_addr, brick, addrlen);
|
|
|
ca3909 |
+ brick_addr[addrlen] = '\0';
|
|
|
ca3909 |
+ ret = getaddrinfo(brick_addr, NULL, NULL, &ai_info);
|
|
|
ca3909 |
if (ret != 0) {
|
|
|
ca3909 |
ret = 0;
|
|
|
ca3909 |
gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_HOSTNAME_RESOLVE_FAIL,
|
|
|
ca3909 |
- "unable to resolve "
|
|
|
ca3909 |
- "host name");
|
|
|
ca3909 |
+ "unable to resolve host name for addr %s", brick_addr);
|
|
|
ca3909 |
goto out;
|
|
|
ca3909 |
}
|
|
|
ca3909 |
ai_list_tmp1 = MALLOC(sizeof(addrinfo_list_t));
|
|
|
ca3909 |
--
|
|
|
ca3909 |
1.8.3.1
|
|
|
ca3909 |
|