|
 |
3604df |
From c1836d74994d75deda6666d991316d964a00978c Mon Sep 17 00:00:00 2001
|
|
|
3604df |
From: Ashish Pandey <aspandey@redhat.com>
|
|
|
3604df |
Date: Fri, 20 Jan 2017 15:57:22 +0530
|
|
|
3604df |
Subject: [PATCH 275/275] cluster/disperse: Do not log fop failed for lockless
|
|
|
3604df |
fops
|
|
|
3604df |
|
|
|
3604df |
Problem: Operation failed messages are getting logged
|
|
|
3604df |
based on the callbacks of lockless fop's. If a fop does
|
|
|
3604df |
not take a lock, it is possible that it will get some
|
|
|
3604df |
out of sync xattr, iatts. We can not depend on these
|
|
|
3604df |
callback to psay that the fop has failed.
|
|
|
3604df |
|
|
|
3604df |
Solution: Print failed messages only for locked fops.
|
|
|
3604df |
However, heal would still be triggered.
|
|
|
3604df |
|
|
|
3604df |
>Change-Id: I4427402c8c944c23f16073613caa03ea788bead3
|
|
|
3604df |
>BUG: 1414287
|
|
|
3604df |
>Signed-off-by: Ashish Pandey <aspandey@redhat.com>
|
|
|
3604df |
>Reviewed-on: http://review.gluster.org/16435
|
|
|
3604df |
>Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
|
|
|
3604df |
>Smoke: Gluster Build System <jenkins@build.gluster.org>
|
|
|
3604df |
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
|
|
|
3604df |
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
|
|
|
3604df |
>Signed-off-by: Ashish Pandey <aspandey@redhat.com>
|
|
|
3604df |
|
|
|
3604df |
Change-Id: I658209f2ba376b4f23385a7e6df541d0b1e23b0c
|
|
|
3604df |
BUG: 1406322
|
|
|
3604df |
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
|
|
|
3604df |
Reviewed-on: https://code.engineering.redhat.com/gerrit/95854
|
|
|
3604df |
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
|
|
|
3604df |
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
|
|
|
3604df |
---
|
|
|
3604df |
xlators/cluster/ec/src/ec-common.c | 16 +++++++++-------
|
|
|
3604df |
1 file changed, 9 insertions(+), 7 deletions(-)
|
|
|
3604df |
|
|
|
3604df |
diff --git a/xlators/cluster/ec/src/ec-common.c b/xlators/cluster/ec/src/ec-common.c
|
|
|
3604df |
index c068cc3..3fbbe49 100644
|
|
|
3604df |
--- a/xlators/cluster/ec/src/ec-common.c
|
|
|
3604df |
+++ b/xlators/cluster/ec/src/ec-common.c
|
|
|
3604df |
@@ -107,13 +107,15 @@ void ec_check_status(ec_fop_data_t * fop)
|
|
|
3604df |
}
|
|
|
3604df |
}
|
|
|
3604df |
|
|
|
3604df |
- gf_msg (fop->xl->name, GF_LOG_WARNING, 0,
|
|
|
3604df |
- EC_MSG_OP_FAIL_ON_SUBVOLS,
|
|
|
3604df |
- "Operation failed on some "
|
|
|
3604df |
- "subvolumes (up=%lX, mask=%lX, "
|
|
|
3604df |
- "remaining=%lX, good=%lX, bad=%lX)",
|
|
|
3604df |
- ec->xl_up, fop->mask, fop->remaining, fop->good,
|
|
|
3604df |
- ec->xl_up & ~(fop->remaining | fop->good));
|
|
|
3604df |
+ if (fop->lock_count > 0) {
|
|
|
3604df |
+ gf_msg (fop->xl->name, GF_LOG_WARNING, 0,
|
|
|
3604df |
+ EC_MSG_OP_FAIL_ON_SUBVOLS,
|
|
|
3604df |
+ "Operation failed on some "
|
|
|
3604df |
+ "subvolumes (up=%lX, mask=%lX, "
|
|
|
3604df |
+ "remaining=%lX, good=%lX, bad=%lX)",
|
|
|
3604df |
+ ec->xl_up, fop->mask, fop->remaining, fop->good,
|
|
|
3604df |
+ ec->xl_up & ~(fop->remaining | fop->good));
|
|
|
3604df |
+ }
|
|
|
3604df |
|
|
|
3604df |
if (fop->use_fd)
|
|
|
3604df |
{
|
|
|
3604df |
--
|
|
|
3604df |
2.9.3
|
|
|
3604df |
|