|
 |
74b1de |
From d5f931b334ac7abccaf30d277ce3ca9cfae0da5b Mon Sep 17 00:00:00 2001
|
|
|
74b1de |
From: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
74b1de |
Date: Mon, 29 Jul 2019 14:08:37 +0530
|
|
|
74b1de |
Subject: [PATCH 273/276] cluster/ec: Fix reopen flags to avoid misbehavior
|
|
|
74b1de |
|
|
|
74b1de |
Problem:
|
|
|
74b1de |
when a file needs to be re-opened O_APPEND and O_EXCL
|
|
|
74b1de |
flags are not filtered in EC.
|
|
|
74b1de |
|
|
|
74b1de |
- O_APPEND should be filtered because EC doesn't send O_APPEND below EC for
|
|
|
74b1de |
open to make sure writes happen on the individual fragments instead of at the
|
|
|
74b1de |
end of the file.
|
|
|
74b1de |
|
|
|
74b1de |
- O_EXCL should be filtered because shd could have created the file so even
|
|
|
74b1de |
when file exists open should succeed
|
|
|
74b1de |
|
|
|
74b1de |
- O_CREAT should be filtered because open happens with gfid as parameter. So
|
|
|
74b1de |
open fop will create just the gfid which will lead to problems.
|
|
|
74b1de |
|
|
|
74b1de |
Fix:
|
|
|
74b1de |
Filter out these two flags in reopen.
|
|
|
74b1de |
|
|
|
74b1de |
Upstream-patch:https://review.gluster.org/#/c/glusterfs/+/23121/
|
|
|
74b1de |
Change-Id: Ia280470fcb5188a09caa07bf665a2a94bce23bc4
|
|
|
74b1de |
fixes: bz#1735514
|
|
|
74b1de |
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
74b1de |
Reviewed-on: https://code.engineering.redhat.com/gerrit/177977
|
|
|
74b1de |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
74b1de |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
74b1de |
---
|
|
|
74b1de |
xlators/cluster/ec/src/ec-common.c | 4 +++-
|
|
|
74b1de |
xlators/cluster/ec/src/ec-inode-write.c | 7 +++++--
|
|
|
74b1de |
2 files changed, 8 insertions(+), 3 deletions(-)
|
|
|
74b1de |
|
|
|
74b1de |
diff --git a/xlators/cluster/ec/src/ec-common.c b/xlators/cluster/ec/src/ec-common.c
|
|
|
74b1de |
index 28b31c9..5fb4610 100644
|
|
|
74b1de |
--- a/xlators/cluster/ec/src/ec-common.c
|
|
|
74b1de |
+++ b/xlators/cluster/ec/src/ec-common.c
|
|
|
74b1de |
@@ -101,6 +101,7 @@ ec_fix_open(ec_fop_data_t *fop, uintptr_t mask)
|
|
|
74b1de |
{
|
|
|
74b1de |
uintptr_t need_open = 0;
|
|
|
74b1de |
int ret = 0;
|
|
|
74b1de |
+ int32_t flags = 0;
|
|
|
74b1de |
loc_t loc = {
|
|
|
74b1de |
0,
|
|
|
74b1de |
};
|
|
|
74b1de |
@@ -121,6 +122,7 @@ ec_fix_open(ec_fop_data_t *fop, uintptr_t mask)
|
|
|
74b1de |
goto out;
|
|
|
74b1de |
}
|
|
|
74b1de |
|
|
|
74b1de |
+ flags = fop->fd->flags & (~(O_TRUNC | O_APPEND | O_CREAT | O_EXCL));
|
|
|
74b1de |
if (IA_IFDIR == fop->fd->inode->ia_type) {
|
|
|
74b1de |
ec_opendir(fop->frame, fop->xl, need_open,
|
|
|
74b1de |
EC_MINIMUM_ONE | EC_FOP_NO_PROPAGATE_ERROR, NULL, NULL,
|
|
|
74b1de |
@@ -128,7 +130,7 @@ ec_fix_open(ec_fop_data_t *fop, uintptr_t mask)
|
|
|
74b1de |
} else {
|
|
|
74b1de |
ec_open(fop->frame, fop->xl, need_open,
|
|
|
74b1de |
EC_MINIMUM_ONE | EC_FOP_NO_PROPAGATE_ERROR, NULL, NULL, &loc,
|
|
|
74b1de |
- fop->fd->flags & (~O_TRUNC), fop->fd, NULL);
|
|
|
74b1de |
+ flags, fop->fd, NULL);
|
|
|
74b1de |
}
|
|
|
74b1de |
|
|
|
74b1de |
out:
|
|
|
74b1de |
diff --git a/xlators/cluster/ec/src/ec-inode-write.c b/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
74b1de |
index 4f35b6d..2f28e11 100644
|
|
|
74b1de |
--- a/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
74b1de |
+++ b/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
74b1de |
@@ -1985,10 +1985,13 @@ ec_get_lock_good_mask(inode_t *inode, xlator_t *xl)
|
|
|
74b1de |
LOCK(&inode->lock);
|
|
|
74b1de |
{
|
|
|
74b1de |
ictx = __ec_inode_get(inode, xl);
|
|
|
74b1de |
- lock = ictx->inode_lock;
|
|
|
74b1de |
+ if (ictx)
|
|
|
74b1de |
+ lock = ictx->inode_lock;
|
|
|
74b1de |
}
|
|
|
74b1de |
UNLOCK(&inode->lock);
|
|
|
74b1de |
- return lock->good_mask;
|
|
|
74b1de |
+ if (lock)
|
|
|
74b1de |
+ return lock->good_mask;
|
|
|
74b1de |
+ return 0;
|
|
|
74b1de |
}
|
|
|
74b1de |
|
|
|
74b1de |
void
|
|
|
74b1de |
--
|
|
|
74b1de |
1.8.3.1
|
|
|
74b1de |
|