|
 |
50dc83 |
From 220b95085847b5f6a9e5bee7a9519efe72600e6a Mon Sep 17 00:00:00 2001
|
|
|
50dc83 |
From: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
50dc83 |
Date: Thu, 18 Jul 2019 11:25:31 +0530
|
|
|
50dc83 |
Subject: [PATCH 272/276] cluster/ec: Always read from good-mask
|
|
|
50dc83 |
|
|
|
50dc83 |
There are cases where fop->mask may have fop->healing added
|
|
|
50dc83 |
and readv shouldn't be wound on fop->healing. To avoid this
|
|
|
50dc83 |
always wind readv to lock->good_mask
|
|
|
50dc83 |
|
|
|
50dc83 |
Upstream-patch: https://review.gluster.org/c/glusterfs/+/23069
|
|
|
50dc83 |
fixes: bz#1730914
|
|
|
50dc83 |
Change-Id: I2226ef0229daf5ff315d51e868b980ee48060b87
|
|
|
50dc83 |
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
50dc83 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/177976
|
|
|
50dc83 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
50dc83 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
50dc83 |
---
|
|
|
50dc83 |
xlators/cluster/ec/src/ec-common.c | 3 +++
|
|
|
50dc83 |
xlators/cluster/ec/src/ec-inode-write.c | 27 ++++++++++++++++++++++-----
|
|
|
50dc83 |
2 files changed, 25 insertions(+), 5 deletions(-)
|
|
|
50dc83 |
|
|
|
50dc83 |
diff --git a/xlators/cluster/ec/src/ec-common.c b/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
index db1ff5b..28b31c9 100644
|
|
|
50dc83 |
--- a/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
+++ b/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
@@ -654,6 +654,9 @@ ec_child_select(ec_fop_data_t *fop)
|
|
|
50dc83 |
* unlock should go on all subvols where lock is performed*/
|
|
|
50dc83 |
if (fop->parent && !ec_internal_op(fop)) {
|
|
|
50dc83 |
fop->mask &= (fop->parent->mask & ~fop->parent->healing);
|
|
|
50dc83 |
+ if (ec_is_data_fop(fop->id)) {
|
|
|
50dc83 |
+ fop->healing |= fop->parent->healing;
|
|
|
50dc83 |
+ }
|
|
|
50dc83 |
}
|
|
|
50dc83 |
|
|
|
50dc83 |
if ((fop->mask & ~ec->xl_up) != 0) {
|
|
|
50dc83 |
diff --git a/xlators/cluster/ec/src/ec-inode-write.c b/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
50dc83 |
index a45e6d6..4f35b6d 100644
|
|
|
50dc83 |
--- a/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
50dc83 |
+++ b/xlators/cluster/ec/src/ec-inode-write.c
|
|
|
50dc83 |
@@ -1977,6 +1977,20 @@ ec_get_and_merge_stripe(ec_t *ec, ec_fop_data_t *fop, ec_stripe_part_t which)
|
|
|
50dc83 |
return found;
|
|
|
50dc83 |
}
|
|
|
50dc83 |
|
|
|
50dc83 |
+static uintptr_t
|
|
|
50dc83 |
+ec_get_lock_good_mask(inode_t *inode, xlator_t *xl)
|
|
|
50dc83 |
+{
|
|
|
50dc83 |
+ ec_lock_t *lock = NULL;
|
|
|
50dc83 |
+ ec_inode_t *ictx = NULL;
|
|
|
50dc83 |
+ LOCK(&inode->lock);
|
|
|
50dc83 |
+ {
|
|
|
50dc83 |
+ ictx = __ec_inode_get(inode, xl);
|
|
|
50dc83 |
+ lock = ictx->inode_lock;
|
|
|
50dc83 |
+ }
|
|
|
50dc83 |
+ UNLOCK(&inode->lock);
|
|
|
50dc83 |
+ return lock->good_mask;
|
|
|
50dc83 |
+}
|
|
|
50dc83 |
+
|
|
|
50dc83 |
void
|
|
|
50dc83 |
ec_writev_start(ec_fop_data_t *fop)
|
|
|
50dc83 |
{
|
|
|
50dc83 |
@@ -2022,9 +2036,10 @@ ec_writev_start(ec_fop_data_t *fop)
|
|
|
50dc83 |
err = -ENOMEM;
|
|
|
50dc83 |
goto failed_xdata;
|
|
|
50dc83 |
}
|
|
|
50dc83 |
- ec_readv(fop->frame, fop->xl, -1, EC_MINIMUM_MIN,
|
|
|
50dc83 |
- ec_writev_merge_head, NULL, fd, ec->stripe_size,
|
|
|
50dc83 |
- fop->offset, 0, xdata);
|
|
|
50dc83 |
+ ec_readv(fop->frame, fop->xl,
|
|
|
50dc83 |
+ ec_get_lock_good_mask(fop->fd->inode, fop->xl),
|
|
|
50dc83 |
+ EC_MINIMUM_MIN, ec_writev_merge_head, NULL, fd,
|
|
|
50dc83 |
+ ec->stripe_size, fop->offset, 0, xdata);
|
|
|
50dc83 |
}
|
|
|
50dc83 |
} else {
|
|
|
50dc83 |
memset(fop->vector[0].iov_base, 0, fop->head);
|
|
|
50dc83 |
@@ -2047,8 +2062,10 @@ ec_writev_start(ec_fop_data_t *fop)
|
|
|
50dc83 |
err = -ENOMEM;
|
|
|
50dc83 |
goto failed_xdata;
|
|
|
50dc83 |
}
|
|
|
50dc83 |
- ec_readv(fop->frame, fop->xl, -1, EC_MINIMUM_MIN,
|
|
|
50dc83 |
- ec_writev_merge_tail, NULL, fd, ec->stripe_size,
|
|
|
50dc83 |
+ ec_readv(fop->frame, fop->xl,
|
|
|
50dc83 |
+ ec_get_lock_good_mask(fop->fd->inode, fop->xl),
|
|
|
50dc83 |
+ EC_MINIMUM_MIN, ec_writev_merge_tail, NULL, fd,
|
|
|
50dc83 |
+ ec->stripe_size,
|
|
|
50dc83 |
fop->offset + fop->size - ec->stripe_size, 0, xdata);
|
|
|
50dc83 |
}
|
|
|
50dc83 |
} else {
|
|
|
50dc83 |
--
|
|
|
50dc83 |
1.8.3.1
|
|
|
50dc83 |
|