50dc83
From 872e344c0ab40c37b1872c32f5d5fddc097a1460 Mon Sep 17 00:00:00 2001
50dc83
From: Atin Mukherjee <amukherj@redhat.com>
50dc83
Date: Mon, 5 Aug 2019 21:16:35 +0530
50dc83
Subject: [PATCH 268/276] rpc/transport: have default listen-port
50dc83
50dc83
With release-6, we now can have transport.socket.listen-port parameter
50dc83
configurable in glusterd.vol. However the default value wasn't defined
50dc83
in the code and this breaks the backward compatibility where if one has
50dc83
a modified glusterd.vol file, then post upgrade the same file will be
50dc83
retained and the new changes introduced as part of the release wouldn't
50dc83
be available in the glusterd.vol. So it's important that for each new
50dc83
options introduced in glusterd.vol file backward compatibility is
50dc83
guaranteed.
50dc83
50dc83
> upstream patch : https://review.gluster.org/#/c/glusterfs/+/23160/
50dc83
50dc83
>Fixes: bz#1737676
50dc83
>Change-Id: I776b28bff786320cda299fe673d824024dc9803e
50dc83
>Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
50dc83
50dc83
BUG: 1734534
50dc83
Change-Id: I776b28bff786320cda299fe673d824024dc9803e
50dc83
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
50dc83
Reviewed-on: https://code.engineering.redhat.com/gerrit/177862
50dc83
Tested-by: RHGS Build Bot <nigelb@redhat.com>
50dc83
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
50dc83
---
50dc83
 rpc/rpc-transport/socket/src/name.c | 2 ++
50dc83
 1 file changed, 2 insertions(+)
50dc83
50dc83
diff --git a/rpc/rpc-transport/socket/src/name.c b/rpc/rpc-transport/socket/src/name.c
50dc83
index ca14402..7f18cc4 100644
50dc83
--- a/rpc/rpc-transport/socket/src/name.c
50dc83
+++ b/rpc/rpc-transport/socket/src/name.c
50dc83
@@ -367,6 +367,8 @@ af_inet_server_get_local_sockaddr(rpc_transport_t *this, struct sockaddr *addr,
50dc83
     listen_port_data = dict_get(options, "transport.socket.listen-port");
50dc83
     if (listen_port_data) {
50dc83
         listen_port = data_to_uint16(listen_port_data);
50dc83
+    } else {
50dc83
+        listen_port = GF_DEFAULT_SOCKET_LISTEN_PORT;
50dc83
     }
50dc83
 
50dc83
     listen_host_data = dict_get(options, "transport.socket.bind-address");
50dc83
-- 
50dc83
1.8.3.1
50dc83