|
 |
d1681e |
From 717fab7db9afb3d2f512fcdb7a952eb57b67e8dd Mon Sep 17 00:00:00 2001
|
|
|
d1681e |
From: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
d1681e |
Date: Thu, 10 May 2018 16:54:44 +0530
|
|
|
d1681e |
Subject: [PATCH 268/271] dht: Excessive 'dict is null' logs in
|
|
|
d1681e |
dht_discover_complete
|
|
|
d1681e |
|
|
|
d1681e |
Problem: In Geo-Rep setup excessive "dict is null" logs in
|
|
|
d1681e |
dht_discover_complete while xattr is NULL
|
|
|
d1681e |
|
|
|
d1681e |
Solution: To avoid the logs update a condition in dht_discover_complete
|
|
|
d1681e |
|
|
|
d1681e |
> BUG: 1576767
|
|
|
d1681e |
> Change-Id: Ic7aad712d9b6d69b85b76e4fdf2881adb0512237
|
|
|
d1681e |
> fixes: bz#1576767
|
|
|
d1681e |
> (cherry pick from commit 08dcb1c2bf02bba313d3bfc8fbc1c8ea63296321)
|
|
|
d1681e |
> (Upstream review link https://review.gluster.org/#/c/20001/)
|
|
|
d1681e |
|
|
|
d1681e |
BUG: 1565577
|
|
|
d1681e |
Change-Id: I1b1327eeef05fa261c814069a3bdd75653b37bd1
|
|
|
d1681e |
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
d1681e |
Reviewed-on: https://code.engineering.redhat.com/gerrit/138490
|
|
|
d1681e |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
d1681e |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
d1681e |
---
|
|
|
d1681e |
xlators/cluster/dht/src/dht-common.c | 3 ++-
|
|
|
d1681e |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
d1681e |
|
|
|
d1681e |
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c
|
|
|
d1681e |
index ec1628a..feeaa3f 100644
|
|
|
d1681e |
--- a/xlators/cluster/dht/src/dht-common.c
|
|
|
d1681e |
+++ b/xlators/cluster/dht/src/dht-common.c
|
|
|
d1681e |
@@ -748,7 +748,8 @@ cleanup:
|
|
|
d1681e |
done:
|
|
|
d1681e |
dht_set_fixed_dir_stat (&local->postparent);
|
|
|
d1681e |
/* Delete mds xattr at the time of STACK UNWIND */
|
|
|
d1681e |
- GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr);
|
|
|
d1681e |
+ if (local->xattr)
|
|
|
d1681e |
+ GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr);
|
|
|
d1681e |
|
|
|
d1681e |
DHT_STACK_UNWIND (lookup, main_frame, local->op_ret, local->op_errno,
|
|
|
d1681e |
local->inode, &local->stbuf, local->xattr,
|
|
|
d1681e |
--
|
|
|
d1681e |
1.8.3.1
|
|
|
d1681e |
|