d1681e
From 2de9ac218241648f1ec86b73aac728d713862a30 Mon Sep 17 00:00:00 2001
d1681e
From: moagrawa <moagrawa@redhat.com>
d1681e
Date: Fri, 4 May 2018 16:17:42 +0530
d1681e
Subject: [PATCH 254/260] posix: Avoid changelog retries for geo-rep
d1681e
d1681e
Problem: georep is slowdown to migrate directory
d1681e
         from master volume to slave volume due to lot
d1681e
         of changelog retries
d1681e
d1681e
Solution: Update the condition in posix_getxattr to
d1681e
          ignore MDS_INTERNAL_XATTR as it(posix) ignored
d1681e
          other internal xattrs
d1681e
d1681e
> BUG: 1571069
d1681e
> Change-Id: I4d91ec73e5b1ca1cb3ecf0825ab9f49e261da70e
d1681e
> fixes: bz#1571069
d1681e
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
d1681e
> (cherry picked from commit f46047ea0f36084f4456887673552a01b926382d)
d1681e
> (Reviewed on: https://review.gluster.org/#/c/19930/)
d1681e
d1681e
BUG: 1565577
d1681e
Change-Id: I85b2e8ed4adcbe34ee5a03acd068693978e9cfe4
d1681e
Signed-off-by: moagrawa <moagrawa@redhat.com>
d1681e
Reviewed-on: https://code.engineering.redhat.com/gerrit/137779
d1681e
Tested-by: RHGS Build Bot <nigelb@redhat.com>
d1681e
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
d1681e
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
d1681e
---
d1681e
 xlators/storage/posix/src/posix.c | 33 +++++++++++++++++++++++++++++++++
d1681e
 1 file changed, 33 insertions(+)
d1681e
d1681e
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c
d1681e
index c680e3f..416d9e4 100644
d1681e
--- a/xlators/storage/posix/src/posix.c
d1681e
+++ b/xlators/storage/posix/src/posix.c
d1681e
@@ -27,6 +27,7 @@
d1681e
 #include <sys/uio.h>
d1681e
 #include <unistd.h>
d1681e
 #include <ftw.h>
d1681e
+#include <regex.h>
d1681e
 
d1681e
 #ifndef GF_BSD_HOST_OS
d1681e
 #include <alloca.h>
d1681e
@@ -4625,6 +4626,27 @@ out:
d1681e
         return ret;
d1681e
 }
d1681e
 
d1681e
+gf_boolean_t
d1681e
+posix_is_mds_xattr (const char *name)
d1681e
+{
d1681e
+        regex_t regcmpl;
d1681e
+        char *key = {"trusted.glusterfs.*.mds$"};
d1681e
+        regmatch_t result[1] = {{0} };
d1681e
+        gf_boolean_t status = _gf_false;
d1681e
+
d1681e
+        if (regcomp (&regcmpl, key, REG_EXTENDED)) {
d1681e
+                goto out;
d1681e
+        }
d1681e
+        if (!regexec (&regcmpl, name, 1, result, 0)) {
d1681e
+                status = _gf_true;
d1681e
+                goto out;
d1681e
+        }
d1681e
+out:
d1681e
+        regfree(&regcmpl);
d1681e
+        return status;
d1681e
+}
d1681e
+
d1681e
+
d1681e
 /**
d1681e
  * posix_getxattr - this function returns a dictionary with all the
d1681e
  *                  key:value pair present as xattr. used for
d1681e
@@ -4680,6 +4702,13 @@ posix_getxattr (call_frame_t *frame, xlator_t *this,
d1681e
                 goto out;
d1681e
         }
d1681e
 
d1681e
+        if (name && posix_is_mds_xattr (name)) {
d1681e
+                op_ret = -1;
d1681e
+                op_errno = ENOATTR;
d1681e
+                goto out;
d1681e
+        }
d1681e
+
d1681e
+
d1681e
         if (loc->inode && IA_ISDIR(loc->inode->ia_type) && name &&
d1681e
             ZR_FILE_CONTENT_REQUEST(name)) {
d1681e
                 ret = posix_get_file_contents (this, loc->gfid, &name[15],
d1681e
@@ -5049,6 +5078,10 @@ posix_getxattr (call_frame_t *frame, xlator_t *this,
d1681e
                         goto ignore;
d1681e
                 }
d1681e
 
d1681e
+                if (posix_is_mds_xattr (keybuffer)) {
d1681e
+                        goto ignore;
d1681e
+                }
d1681e
+
d1681e
                 memset (value_buf, '\0', sizeof(value_buf));
d1681e
                 have_val = _gf_false;
d1681e
                 size = sys_lgetxattr (real_path, keybuffer, value_buf,
d1681e
-- 
d1681e
1.8.3.1
d1681e