e3c68b
From 7a04fb9999f5d25c17f5593eed5e98d0f5a1932d Mon Sep 17 00:00:00 2001
e3c68b
From: karthik-us <ksubrahm@redhat.com>
e3c68b
Date: Mon, 15 Jul 2019 14:30:52 +0530
e3c68b
Subject: [PATCH 251/255] tests: Fix
e3c68b
 bug-1717819-metadata-split-brain-detection.t failure
e3c68b
e3c68b
<Backport of: https://review.gluster.org/#/c/glusterfs/+/23043/>
e3c68b
e3c68b
Problem:
e3c68b
tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t fails
e3c68b
intermittently in test cases #49 & #50, which compare the values of the
e3c68b
user set xattr values after enabling the heal. We are not waiting for
e3c68b
the heal to complete before comparing those values, which might lead
e3c68b
those tests to fail.
e3c68b
e3c68b
Fix:
e3c68b
Wait till the HEAL-TIMEOUT before comparing the xattr values.
e3c68b
Also cheking for the shd to come up and the bricks to connect to the shd
e3c68b
process in another case.
e3c68b
e3c68b
Change-Id: I0021c2d5d251111c695e2bf18c63e8189e456114
e3c68b
fixes: bz#1704562
e3c68b
Signed-off-by: karthik-us <ksubrahm@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/176071
e3c68b
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
---
e3c68b
 tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t | 6 ++++++
e3c68b
 1 file changed, 6 insertions(+)
e3c68b
e3c68b
diff --git a/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t b/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
e3c68b
index 94b8bf3..76d1f21 100644
e3c68b
--- a/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
e3c68b
+++ b/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
e3c68b
@@ -76,6 +76,10 @@ EXPECT_WITHIN $HEAL_TIMEOUT "^1$" get_pending_heal_count $V0
e3c68b
 
e3c68b
 # Launch heal
e3c68b
 TEST $CLI volume heal $V0 enable
e3c68b
+EXPECT_WITHIN $PROCESS_UP_TIMEOUT "^Y$" glustershd_up_status
e3c68b
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 0
e3c68b
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 1
e3c68b
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 2
e3c68b
 TEST $CLI volume heal $V0
e3c68b
 EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0
e3c68b
 
e3c68b
@@ -117,6 +121,8 @@ EXPECT_WITHIN $PROCESS_UP_TIMEOUT "^Y$" glustershd_up_status
e3c68b
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 0
e3c68b
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 1
e3c68b
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 2
e3c68b
+TEST $CLI volume heal $V0
e3c68b
+EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0
e3c68b
 
e3c68b
 B0_XATTR=$(getfattr -n 'user.metadata' --absolute-names --only-values $B0/${V0}0/dir/file)
e3c68b
 B1_XATTR=$(getfattr -n 'user.metadata' --absolute-names --only-values $B0/${V0}1/dir/file)
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b