17b94a
From 7a04fb9999f5d25c17f5593eed5e98d0f5a1932d Mon Sep 17 00:00:00 2001
17b94a
From: karthik-us <ksubrahm@redhat.com>
17b94a
Date: Mon, 15 Jul 2019 14:30:52 +0530
17b94a
Subject: [PATCH 251/255] tests: Fix
17b94a
 bug-1717819-metadata-split-brain-detection.t failure
17b94a
17b94a
<Backport of: https://review.gluster.org/#/c/glusterfs/+/23043/>
17b94a
17b94a
Problem:
17b94a
tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t fails
17b94a
intermittently in test cases #49 & #50, which compare the values of the
17b94a
user set xattr values after enabling the heal. We are not waiting for
17b94a
the heal to complete before comparing those values, which might lead
17b94a
those tests to fail.
17b94a
17b94a
Fix:
17b94a
Wait till the HEAL-TIMEOUT before comparing the xattr values.
17b94a
Also cheking for the shd to come up and the bricks to connect to the shd
17b94a
process in another case.
17b94a
17b94a
Change-Id: I0021c2d5d251111c695e2bf18c63e8189e456114
17b94a
fixes: bz#1704562
17b94a
Signed-off-by: karthik-us <ksubrahm@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/176071
17b94a
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
---
17b94a
 tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t | 6 ++++++
17b94a
 1 file changed, 6 insertions(+)
17b94a
17b94a
diff --git a/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t b/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
17b94a
index 94b8bf3..76d1f21 100644
17b94a
--- a/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
17b94a
+++ b/tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t
17b94a
@@ -76,6 +76,10 @@ EXPECT_WITHIN $HEAL_TIMEOUT "^1$" get_pending_heal_count $V0
17b94a
 
17b94a
 # Launch heal
17b94a
 TEST $CLI volume heal $V0 enable
17b94a
+EXPECT_WITHIN $PROCESS_UP_TIMEOUT "^Y$" glustershd_up_status
17b94a
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 0
17b94a
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 1
17b94a
+EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 2
17b94a
 TEST $CLI volume heal $V0
17b94a
 EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0
17b94a
 
17b94a
@@ -117,6 +121,8 @@ EXPECT_WITHIN $PROCESS_UP_TIMEOUT "^Y$" glustershd_up_status
17b94a
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 0
17b94a
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 1
17b94a
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "^1$" afr_child_up_status_in_shd $V0 2
17b94a
+TEST $CLI volume heal $V0
17b94a
+EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0
17b94a
 
17b94a
 B0_XATTR=$(getfattr -n 'user.metadata' --absolute-names --only-values $B0/${V0}0/dir/file)
17b94a
 B1_XATTR=$(getfattr -n 'user.metadata' --absolute-names --only-values $B0/${V0}1/dir/file)
17b94a
-- 
17b94a
1.8.3.1
17b94a