|
 |
17b94a |
From 1864a4f382f3031915e8126440a1561035487e49 Mon Sep 17 00:00:00 2001
|
|
|
17b94a |
From: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
17b94a |
Date: Thu, 11 Jul 2019 12:53:20 +0530
|
|
|
17b94a |
Subject: [PATCH 249/255] Revert "client/fini: return fini after rpc cleanup"
|
|
|
17b94a |
|
|
|
17b94a |
This reverts commit d79cb2cdff6fe8d962c9ac095a7541ddf500302b.
|
|
|
17b94a |
|
|
|
17b94a |
BUG: 1471742
|
|
|
17b94a |
Change-Id: I15e6544d47fb7b6002c3b44de3fe0b2a13c84f51
|
|
|
17b94a |
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
17b94a |
Reviewed-on: https://code.engineering.redhat.com/gerrit/175958
|
|
|
17b94a |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
17b94a |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
17b94a |
---
|
|
|
17b94a |
xlators/protocol/client/src/client.c | 25 +++++--------------------
|
|
|
17b94a |
xlators/protocol/client/src/client.h | 6 ------
|
|
|
17b94a |
2 files changed, 5 insertions(+), 26 deletions(-)
|
|
|
17b94a |
|
|
|
17b94a |
diff --git a/xlators/protocol/client/src/client.c b/xlators/protocol/client/src/client.c
|
|
|
17b94a |
index 95e4be5..532ef35 100644
|
|
|
17b94a |
--- a/xlators/protocol/client/src/client.c
|
|
|
17b94a |
+++ b/xlators/protocol/client/src/client.c
|
|
|
17b94a |
@@ -49,12 +49,11 @@ client_fini_complete(xlator_t *this)
|
|
|
17b94a |
if (!conf->destroy)
|
|
|
17b94a |
return 0;
|
|
|
17b94a |
|
|
|
17b94a |
- pthread_mutex_lock(&conf->lock);
|
|
|
17b94a |
- {
|
|
|
17b94a |
- conf->fini_completed = _gf_true;
|
|
|
17b94a |
- pthread_cond_broadcast(&conf->fini_complete_cond);
|
|
|
17b94a |
- }
|
|
|
17b94a |
- pthread_mutex_unlock(&conf->lock);
|
|
|
17b94a |
+ this->private = NULL;
|
|
|
17b94a |
+
|
|
|
17b94a |
+ pthread_spin_destroy(&conf->fd_lock);
|
|
|
17b94a |
+ pthread_mutex_destroy(&conf->lock);
|
|
|
17b94a |
+ GF_FREE(conf);
|
|
|
17b94a |
|
|
|
17b94a |
out:
|
|
|
17b94a |
return 0;
|
|
|
17b94a |
@@ -2730,7 +2729,6 @@ init(xlator_t *this)
|
|
|
17b94a |
goto out;
|
|
|
17b94a |
|
|
|
17b94a |
pthread_mutex_init(&conf->lock, NULL);
|
|
|
17b94a |
- pthread_cond_init(&conf->fini_complete_cond, NULL);
|
|
|
17b94a |
pthread_spin_init(&conf->fd_lock, 0);
|
|
|
17b94a |
INIT_LIST_HEAD(&conf->saved_fds);
|
|
|
17b94a |
|
|
|
17b94a |
@@ -2789,7 +2787,6 @@ fini(xlator_t *this)
|
|
|
17b94a |
if (!conf)
|
|
|
17b94a |
return;
|
|
|
17b94a |
|
|
|
17b94a |
- conf->fini_completed = _gf_false;
|
|
|
17b94a |
conf->destroy = 1;
|
|
|
17b94a |
if (conf->rpc) {
|
|
|
17b94a |
/* cleanup the saved-frames before last unref */
|
|
|
17b94a |
@@ -2797,18 +2794,6 @@ fini(xlator_t *this)
|
|
|
17b94a |
rpc_clnt_unref(conf->rpc);
|
|
|
17b94a |
}
|
|
|
17b94a |
|
|
|
17b94a |
- pthread_mutex_lock(&conf->lock);
|
|
|
17b94a |
- {
|
|
|
17b94a |
- while (!conf->fini_completed)
|
|
|
17b94a |
- pthread_cond_wait(&conf->fini_complete_cond, &conf->lock);
|
|
|
17b94a |
- }
|
|
|
17b94a |
- pthread_mutex_unlock(&conf->lock);
|
|
|
17b94a |
-
|
|
|
17b94a |
- pthread_spin_destroy(&conf->fd_lock);
|
|
|
17b94a |
- pthread_mutex_destroy(&conf->lock);
|
|
|
17b94a |
- pthread_cond_destroy(&conf->fini_complete_cond);
|
|
|
17b94a |
- GF_FREE(conf);
|
|
|
17b94a |
-
|
|
|
17b94a |
/* Saved Fds */
|
|
|
17b94a |
/* TODO: */
|
|
|
17b94a |
|
|
|
17b94a |
diff --git a/xlators/protocol/client/src/client.h b/xlators/protocol/client/src/client.h
|
|
|
17b94a |
index 8dcd72f..f12fa61 100644
|
|
|
17b94a |
--- a/xlators/protocol/client/src/client.h
|
|
|
17b94a |
+++ b/xlators/protocol/client/src/client.h
|
|
|
17b94a |
@@ -235,12 +235,6 @@ typedef struct clnt_conf {
|
|
|
17b94a |
* up, disconnects can be
|
|
|
17b94a |
* logged
|
|
|
17b94a |
*/
|
|
|
17b94a |
-
|
|
|
17b94a |
- gf_boolean_t old_protocol; /* used only for old-protocol testing */
|
|
|
17b94a |
- pthread_cond_t fini_complete_cond; /* Used to wait till we finsh the fini
|
|
|
17b94a |
- compltely, ie client_fini_complete
|
|
|
17b94a |
- to return*/
|
|
|
17b94a |
- gf_boolean_t fini_completed;
|
|
|
17b94a |
} clnt_conf_t;
|
|
|
17b94a |
|
|
|
17b94a |
typedef struct _client_fd_ctx {
|
|
|
17b94a |
--
|
|
|
17b94a |
1.8.3.1
|
|
|
17b94a |
|