|
 |
50dc83 |
From 066189add979d2e4c74463592e5021bd060d5a51 Mon Sep 17 00:00:00 2001
|
|
|
50dc83 |
From: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
50dc83 |
Date: Thu, 11 Jul 2019 12:46:47 +0530
|
|
|
50dc83 |
Subject: [PATCH 241/255] Revert "glusterd/svc: glusterd_svcs_stop should call
|
|
|
50dc83 |
individual wrapper function"
|
|
|
50dc83 |
|
|
|
50dc83 |
This reverts commit 79fff98f9ca5f815cf0227312b9a997d555dad29.
|
|
|
50dc83 |
|
|
|
50dc83 |
BUG: 1471742
|
|
|
50dc83 |
Change-Id: I258040ed9be6bc3b4498c76ed51d59258c55acff
|
|
|
50dc83 |
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
50dc83 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/175950
|
|
|
50dc83 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
50dc83 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
50dc83 |
---
|
|
|
50dc83 |
xlators/mgmt/glusterd/src/glusterd-shd-svc.c | 12 ++----------
|
|
|
50dc83 |
xlators/mgmt/glusterd/src/glusterd-svc-helper.c | 10 +++++-----
|
|
|
50dc83 |
2 files changed, 7 insertions(+), 15 deletions(-)
|
|
|
50dc83 |
|
|
|
50dc83 |
diff --git a/xlators/mgmt/glusterd/src/glusterd-shd-svc.c b/xlators/mgmt/glusterd/src/glusterd-shd-svc.c
|
|
|
50dc83 |
index 981cc87..75f9a07 100644
|
|
|
50dc83 |
--- a/xlators/mgmt/glusterd/src/glusterd-shd-svc.c
|
|
|
50dc83 |
+++ b/xlators/mgmt/glusterd/src/glusterd-shd-svc.c
|
|
|
50dc83 |
@@ -656,18 +656,10 @@ glusterd_shdsvc_stop(glusterd_svc_t *svc, int sig)
|
|
|
50dc83 |
int pid = -1;
|
|
|
50dc83 |
|
|
|
50dc83 |
conf = THIS->private;
|
|
|
50dc83 |
- GF_VALIDATE_OR_GOTO("glusterd", conf, out);
|
|
|
50dc83 |
GF_VALIDATE_OR_GOTO("glusterd", svc, out);
|
|
|
50dc83 |
svc_proc = svc->svc_proc;
|
|
|
50dc83 |
- if (!svc_proc) {
|
|
|
50dc83 |
- /*
|
|
|
50dc83 |
- * This can happen when stop was called on a volume that is not shd
|
|
|
50dc83 |
- * compatible.
|
|
|
50dc83 |
- */
|
|
|
50dc83 |
- gf_msg_debug("glusterd", 0, "svc_proc is null, ie shd already stopped");
|
|
|
50dc83 |
- ret = 0;
|
|
|
50dc83 |
- goto out;
|
|
|
50dc83 |
- }
|
|
|
50dc83 |
+ GF_VALIDATE_OR_GOTO("glusterd", svc_proc, out);
|
|
|
50dc83 |
+ GF_VALIDATE_OR_GOTO("glusterd", conf, out);
|
|
|
50dc83 |
|
|
|
50dc83 |
/* Get volinfo->shd from svc object */
|
|
|
50dc83 |
shd = cds_list_entry(svc, glusterd_shdsvc_t, svc);
|
|
|
50dc83 |
diff --git a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
|
|
|
50dc83 |
index 6a3ca52..f7be394 100644
|
|
|
50dc83 |
--- a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
|
|
|
50dc83 |
+++ b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
|
|
|
50dc83 |
@@ -86,25 +86,25 @@ glusterd_svcs_stop(glusterd_volinfo_t *volinfo)
|
|
|
50dc83 |
priv = this->private;
|
|
|
50dc83 |
GF_ASSERT(priv);
|
|
|
50dc83 |
|
|
|
50dc83 |
- ret = priv->nfs_svc.stop(&(priv->nfs_svc), SIGKILL);
|
|
|
50dc83 |
+ ret = glusterd_svc_stop(&(priv->nfs_svc), SIGKILL);
|
|
|
50dc83 |
if (ret)
|
|
|
50dc83 |
goto out;
|
|
|
50dc83 |
|
|
|
50dc83 |
- ret = priv->quotad_svc.stop(&(priv->quotad_svc), SIGTERM);
|
|
|
50dc83 |
+ ret = glusterd_svc_stop(&(priv->quotad_svc), SIGTERM);
|
|
|
50dc83 |
if (ret)
|
|
|
50dc83 |
goto out;
|
|
|
50dc83 |
|
|
|
50dc83 |
if (volinfo) {
|
|
|
50dc83 |
- ret = volinfo->shd.svc.stop(&(volinfo->shd.svc), SIGTERM);
|
|
|
50dc83 |
+ ret = glusterd_svc_stop(&(volinfo->shd.svc), PROC_START_NO_WAIT);
|
|
|
50dc83 |
if (ret)
|
|
|
50dc83 |
goto out;
|
|
|
50dc83 |
}
|
|
|
50dc83 |
|
|
|
50dc83 |
- ret = priv->bitd_svc.stop(&(priv->bitd_svc), SIGTERM);
|
|
|
50dc83 |
+ ret = glusterd_svc_stop(&(priv->bitd_svc), SIGTERM);
|
|
|
50dc83 |
if (ret)
|
|
|
50dc83 |
goto out;
|
|
|
50dc83 |
|
|
|
50dc83 |
- ret = priv->scrub_svc.stop(&(priv->scrub_svc), SIGTERM);
|
|
|
50dc83 |
+ ret = glusterd_svc_stop(&(priv->scrub_svc), SIGTERM);
|
|
|
50dc83 |
out:
|
|
|
50dc83 |
return ret;
|
|
|
50dc83 |
}
|
|
|
50dc83 |
--
|
|
|
50dc83 |
1.8.3.1
|
|
|
50dc83 |
|